Bug 183864 – [Web Animations] Ensure animationcancel and transitioncancel events are dispatched

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Antoine Quint]

[Web Animations] Ensure animationcancel and transitioncancel events are dispatched

[Antoine Quint]

Created attachment 336223 [details]
Patch

[Dean Jackson]

Comment on attachment 336223 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336223&action=review

> Source/WebCore/animation/AnimationTimeline.cpp:139
> +    if (oldStyle && oldStyle->hasAnimations() && oldStyle->display() != NONE && newStyle.display() == NONE) {

At some point, we should get rid of this NONE value for display and use a better enum.

[WebKit Commit Bot]

Comment on attachment 336223 [details]
Patch

Rejecting attachment 336223 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 336223, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
a/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors
    self._run(tool, options, state)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run
    step(tool, options).run(state)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 54, in run
    if changelog_entry.has_valid_reviewer():
AttributeError: 'NoneType' object has no attribute 'has_valid_reviewer'

Full output: http://webkit-queues.webkit.org/results/7056108

[Antoine Quint]

Committed r229829: <https://trac.webkit.org/changeset/229829>

[Radar WebKit Bug Importer]

<rdar://problem/38724033>

[Jon Lee]

*** Bug 161535 has been marked as a duplicate of this bug. ***