Bug 183862 - Allow the WebContent process to read ViewBridge preferences
Summary: Allow the WebContent process to read ViewBridge preferences
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
: 183707 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-03-21 11:59 PDT by Brent Fulgham
Modified: 2018-03-23 08:11 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.35 KB, patch)
2018-03-21 12:01 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2018-03-21 11:59:57 PDT 
ViewBridge initialization code runs at WebContent process launch time (before entering 'main'), and needs to check certain preferences to decide if it should log. We should allow this preference read to occur.
Comment 1 Brent Fulgham 2018-03-21 12:00:33 PDT 
<rdar://problem/38459456>
Comment 2 Brent Fulgham 2018-03-21 12:01:10 PDT 
Created attachment 336217 [details]
Patch
Comment 3 Alexey Proskuryakov 2018-03-21 13:09:18 PDT 
Comment on attachment 336217 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336217&action=review

> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:460
> +        "com.apple.ViewBridge" ;; Needed for Input elements.

I'd love to know more about how input elements need ViewBridge.
Comment 4 WebKit Commit Bot 2018-03-21 14:10:05 PDT 
Comment on attachment 336217 [details]
Patch

Clearing flags on attachment: 336217

Committed r229823: <https://trac.webkit.org/changeset/229823>
Comment 5 WebKit Commit Bot 2018-03-21 14:10:06 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Brent Fulgham 2018-03-23 08:11:29 PDT 
*** Bug 183707 has been marked as a duplicate of this bug. ***