Bug 183859 - Clean up platform VideoFullscreenLayerManager
Summary: Clean up platform VideoFullscreenLayerManager
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-03-21 10:33 PDT by Eric Carlson
Modified: 2018-03-21 14:14 PDT (History)
3 users (show)

See Also:

Attachments
Patch (59.06 KB, patch)
2018-03-21 13:49 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2018-03-21 10:33:49 PDT 
Every macOS/iOS MediaPlayerPrivate contains identical code for handling fullscreen. Make VideoFullscreenLayerManager an abstract class, add an ObjC version, and put the shared code there.
Comment 1 Radar WebKit Bug Importer 2018-03-21 11:19:47 PDT 
<rdar://problem/38715419>
Comment 2 Eric Carlson 2018-03-21 13:49:15 PDT 
Created attachment 336230 [details]
Patch
Comment 3 WebKit Commit Bot 2018-03-21 14:14:03 PDT 
Comment on attachment 336230 [details]
Patch

Clearing flags on attachment: 336230

Committed r229824: <https://trac.webkit.org/changeset/229824>
Comment 4 WebKit Commit Bot 2018-03-21 14:14:05 PDT 
All reviewed patches have been landed.  Closing bug.