We should avoid doing pointer math with CodeBlock::instructions().begin(). Instead, we should use the operator[] that comes with CodeBlock::instructions() for computing an Instruction*, and use CodeBlock::bytecodeOffset() for computing the bytecode offset of a given Instruction*. These methods will do assertions which helps catch bugs sooner, plus they are more descriptive of the operation we're trying to do.
<rdar://problem/38712184>
Created attachment 336203 [details] proposed patch.
Attachment 336203 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:199: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] Total errors found: 1 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 336203 [details] proposed patch. r=me
Comment on attachment 336203 [details] proposed patch. Will fix issues.
Created attachment 336206 [details] proposed patch.
Created attachment 336208 [details] proposed patch.
Attachment 336208 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:199: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] Total errors found: 1 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 336208 [details] proposed patch. r=me
Thanks for the review. Landed in r229815: <http://trac.webkit.org/r229815>.