Bug 183855 - Compile error when not using IOSurface canvas backing store.
Summary: Compile error when not using IOSurface canvas backing store.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-03-21 09:21 PDT by Per Arne Vollan
Modified: 2018-03-22 07:30 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.48 KB, patch)
2018-03-21 09:28 PDT, Per Arne Vollan 		bfulgham: review+
bfulgham: commit-queue-
Details | Formatted Diff | Diff
Patch (2.20 KB, patch)
2018-03-21 09:42 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews206 for win-future (12.02 MB, application/zip)
2018-03-21 11:34 PDT, EWS Watchlist 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2018-03-21 09:21:37 PDT 
The method IOSurface::createFromImageBuffer is only referenced when IOSurface is used as canvas backing store.
Comment 1 Per Arne Vollan 2018-03-21 09:28:10 PDT 
Created attachment 336198 [details]
Patch
Comment 2 Brent Fulgham 2018-03-21 09:32:06 PDT 
Comment on attachment 336198 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336198&action=review

> Source/WebCore/platform/graphics/cocoa/IOSurface.mm:115
> +#endif

You should probably make this change in the header, too. We do so for "#if HAVE(IOSURFACE_ACCELERATOR)", for example, and in ImageBufferDataCG.h.
Comment 3 Per Arne Vollan 2018-03-21 09:34:49 PDT 
(In reply to Brent Fulgham from comment #2)
> Comment on attachment 336198 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=336198&action=review
> 
> > Source/WebCore/platform/graphics/cocoa/IOSurface.mm:115
> > +#endif
> 
> You should probably make this change in the header, too. We do so for "#if
> HAVE(IOSURFACE_ACCELERATOR)", for example, and in ImageBufferDataCG.h.

Yes, will do. Thanks for reviewing!
Comment 4 Per Arne Vollan 2018-03-21 09:42:55 PDT 
Created attachment 336199 [details]
Patch
Comment 5 WebKit Commit Bot 2018-03-21 10:52:49 PDT 
Comment on attachment 336199 [details]
Patch

Clearing flags on attachment: 336199

Committed r229812: <https://trac.webkit.org/changeset/229812>
Comment 6 EWS Watchlist 2018-03-21 11:34:14 PDT 
Comment on attachment 336198 [details]
Patch

Attachment 336198 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7053725

New failing tests:
http/tests/preload/download_resources.html
Comment 7 EWS Watchlist 2018-03-21 11:34:24 PDT 
Created attachment 336213 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 8 Radar WebKit Bug Importer 2018-03-22 07:30:27 PDT 
<rdar://problem/38751176>