Bug 183821 – [Web Animations] Make imported/mozilla/css-transitions/test_animation-cancel.html pass reliably

• Status: RESOLVED
• Resolution: FIXED
• Component: Animations

[Antoine Quint]

The new tests added under imported/mozilla/css-animations and imported/mozilla/css-transitions are mostly failing reliably, flaky or timing out.

[Radar WebKit Bug Importer]

<rdar://problem/40997034>

[Antoine Quint]

Created attachment 343034 [details]
Patch

[EWS Watchlist]

Comment on attachment 343034 [details]
Patch

Attachment 343034 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/8245755

New failing tests:
http/tests/preload/onload_event.html

[EWS Watchlist]

Created attachment 343048 [details]
Archive of layout-test-results from ews202 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews202  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Antoine Quint]

Committed r232960: <https://trac.webkit.org/changeset/232960>

[Ryan Haddad]

This test is very flaky on debug bots:
--- /Volumes/Data/slave/sierra-debug-tests-wk1/build/layout-test-results/imported/mozilla/css-transitions/test_animation-cancel-expected.txt
+++ /Volumes/Data/slave/sierra-debug-tests-wk1/build/layout-test-results/imported/mozilla/css-transitions/test_animation-cancel-actual.txt
@@ -4,7 +4,7 @@
 PASS After cancelling a finished transition, it can still be re-used 
 PASS After cancelling a transition, updating transition properties doesn't make it live again 
 PASS Setting display:none on an element cancels its transitions 
-PASS Setting display:none cancels transitions on a child element 
+FAIL Setting display:none cancels transitions on a child element assert_equals: expected "idle" but got "running"
 PASS Removing a property from transition-property cancels transitions on that property 
 PASS Setting zero combined duration 
 PASS Changing style to another interpolable value cancels the original transition 

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=imported%2Fmozilla%2Fcss-transitions%2Ftest_animation-cancel.html

[Antoine Quint]

I'll take a look next week.

[Antoine Quint]

I can reproduce the flakiness reliably:

run-webkit-tests --debug --iterations=100 --exit-after-n-failures=1 imported/mozilla/css-transitions/test_animation-cancel.html

[Antoine Quint]

Actually, this flakiness is addressed by the patch for https://bugs.webkit.org/show_bug.cgi?id=183826. So I think it is fine to leave it as-is, we just need to wait on https://bugs.webkit.org/show_bug.cgi?id=183826 landing. Hopefully this will happen early next week when Dean is back from vacation and can review the pending patch.