Bug 183818 – [Web Animations] Make imported/mozilla/css-animations/test_pseudoElement-get-animations.html pass reliably

• Status: RESOLVED
• Resolution: FIXED
• Component: Animations

[Antoine Quint]

The new tests added under imported/mozilla/css-animations and imported/mozilla/css-transitions are mostly failing reliably, flaky or timing out.

[Radar WebKit Bug Importer]

<rdar://problem/40997015>

[Antoine Quint]

Created attachment 343056 [details]
Patch

[Antoine Quint]

Created attachment 343062 [details]
Patch

[EWS Watchlist]

Comment on attachment 343062 [details]
Patch

Attachment 343062 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/8250507

New failing tests:
imported/mozilla/css-animations/test_pseudoElement-get-animations.html

[EWS Watchlist]

Created attachment 343081 [details]
Archive of layout-test-results from ews204 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews204  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Dean Jackson]

Comment on attachment 343062 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343062&action=review

> Source/WebCore/animation/AnimationTimeline.cpp:145
> +Vector<RefPtr<WebAnimation>> AnimationTimeline::animationsForElement(Element& element, bool sorted) const

Use a enum class Ordering::Sorted Ordering::Unsorted rather than a bool parameter

> Source/WebCore/animation/AnimationTimeline.cpp:160
> +                if (lhsTransition->generationTime() == rhsTransition->generationTime())
> +                    return lhsTransition->transitionProperty().utf8() < rhsTransition->transitionProperty().utf8();
> +                return lhsTransition->generationTime() < rhsTransition->generationTime();

Make the logic here match the comment

if (l->genTime != r->genTime)
  return l->genTime < r->genTime;

return l->prop < r->prop

[Antoine Quint]

(In reply to Dean Jackson from comment #6)
> Comment on attachment 343062 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=343062&action=review
> 
> > Source/WebCore/animation/AnimationTimeline.cpp:145
> > +Vector<RefPtr<WebAnimation>> AnimationTimeline::animationsForElement(Element& element, bool sorted) const
> 
> Use a enum class Ordering::Sorted Ordering::Unsorted rather than a bool
> parameter
> 
> > Source/WebCore/animation/AnimationTimeline.cpp:160
> > +                if (lhsTransition->generationTime() == rhsTransition->generationTime())
> > +                    return lhsTransition->transitionProperty().utf8() < rhsTransition->transitionProperty().utf8();
> > +                return lhsTransition->generationTime() < rhsTransition->generationTime();
> 
> Make the logic here match the comment
> 
> if (l->genTime != r->genTime)
>   return l->genTime < r->genTime;
> 
> return l->prop < r->prop

Thanks for the feedback, will address both in the commit.

[Antoine Quint]

Committed r233004: <https://trac.webkit.org/changeset/233004>