RESOLVED FIXED 183811
[WPE] Build failure with ENABLE_VIDEO=OFF when GStreamer is not available 
https://bugs.webkit.org/show_bug.cgi?id=183811
Summary [WPE] Build failure with ENABLE_VIDEO=OFF when GStreamer is not available
Carlos Alberto Lopez Perez
Reported 2018-03-21 05:06:36 PDT
Building WPE with video disabled currently fails if gstreamer is not avaialable (which its expected it won't be if the system doesn't need video). I think this started to happen with r228946 <https://trac.webkit.org/r228946> due to the unconditional inclusion of WebCore/GStreamerUtilities.h which is not guarded by USE(GSTREAMER) The build failure itself: In file included from /home/igalia/clopez/build-wpe-trunk/buildroot-2017.08.2/output/build/wpewebkit-custom/DerivedSources/ForwardingHeaders/WebCore/GStreamerUtilities.h:1:0, from /home/igalia/clopez/build-wpe-trunk/buildroot-2017.08.2/output/build/wpewebkit-custom/Source/WebKit/UIProcess/wpe/WebProcessPoolWPE.cpp:39, from /home/igalia/clopez/build-wpe-trunk/buildroot-2017.08.2/output/build/wpewebkit-custom/DerivedSources/WebKit/unified-sources/UnifiedSource36.cpp:6: /home/igalia/clopez/build-wpe-trunk/buildroot-2017.08.2/output/build/wpewebkit-custom/Source/WebCore/platform/graphics/gstreamer/GStreamerUtilities.h:24:21: fatal error: gst/gst.h: No such file or directory compilation terminated. Source/WebKit/CMakeFiles/WebKit.dir/build.make:16176: recipe for target 'Source/WebKit/CMakeFiles/WebKit.dir/__/__/DerivedSources/WebKit/unified-sources/UnifiedSource36.cpp.o' failed
Attachments
Patch (1.55 KB, patch)
2018-03-21 05:10 PDT, Carlos Alberto Lopez Perez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Alberto Lopez Perez
Comment 1 2018-03-21 05:10:21 PDT
Created attachment 336185 [details] Patch
Carlos Alberto Lopez Perez
Comment 2 2018-03-21 05:37:09 PDT
Comment on attachment 336185 [details] Patch Clearing flags on attachment: 336185 Committed r229803: <https://trac.webkit.org/changeset/229803>
Carlos Alberto Lopez Perez
Comment 3 2018-03-21 05:37:13 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.