Bug 183808 - Update the install name for JavaScriptCore when built with WK_ALTERNATE_FRAMEWORKS_DIR
Summary: Update the install name for JavaScriptCore when built with WK_ALTERNATE_FRAME...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-03-20 22:45 PDT by Tim Horton
Modified: 2018-03-20 23:26 PDT (History)
8 users (show)

See Also:

Attachments
Patch (1.74 KB, patch)
2018-03-20 22:45 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (1.74 KB, patch)
2018-03-20 22:49 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2018-03-20 22:45:22 PDT 
Update the DYLD install name for frameworks built with WK_ALTERNATE_FRAMEWORKS_DIR
Comment 1 Tim Horton 2018-03-20 22:45:35 PDT 
Created attachment 336179 [details]
Patch
Comment 2 Tim Horton 2018-03-20 22:45:51 PDT 
<rdar://problem/38692079>
Comment 3 mitz 2018-03-20 22:48:45 PDT 
Comment on attachment 336179 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336179&action=review

> Source/JavaScriptCore/ChangeLog:3
> +        Update the DYLD install name for frameworks built with WK_ALTERNATE_FRAMEWORKS_DIR

s/DYLD //. Also, you say “frameworks” but only change one framework. Are you going to use this bug for more patches?
Comment 4 Tim Horton 2018-03-20 22:49:54 PDT 
Created attachment 336180 [details]
Patch
Comment 5 WebKit Commit Bot 2018-03-20 23:26:32 PDT 
Comment on attachment 336180 [details]
Patch

Clearing flags on attachment: 336180

Committed r229789: <https://trac.webkit.org/changeset/229789>
Comment 6 WebKit Commit Bot 2018-03-20 23:26:33 PDT 
All reviewed patches have been landed.  Closing bug.