Bug 183795 - We need to do proper bookkeeping of exitOK when inserting constants when sinking NewArrayBuffer
Summary: We need to do proper bookkeeping of exitOK when inserting constants when sink...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-03-20 13:17 PDT by Saam Barati
Modified: 2018-03-20 14:59 PDT (History)
13 users (show)

See Also:

Attachments
patch (2.84 KB, patch)
2018-03-20 13:24 PDT, Saam Barati 		jfbastien: review+
Details | Formatted Diff | Diff
patch for landing (2.83 KB, patch)
2018-03-20 13:32 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2018-03-20 13:17:21 PDT 
...
Comment 1 Saam Barati 2018-03-20 13:18:07 PDT 
<rdar://problem/38298694>
Comment 2 Saam Barati 2018-03-20 13:24:30 PDT 
Created attachment 336145 [details]
patch
Comment 3 Mark Lam 2018-03-20 13:27:44 PDT 
Comment on attachment 336145 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336145&action=review

> Source/JavaScriptCore/ChangeLog:9
> +        We were just assuming that the constans we were inserting were

/constans/constants/
Comment 4 Saam Barati 2018-03-20 13:32:02 PDT 
Created attachment 336146 [details]
patch for landing
Comment 5 WebKit Commit Bot 2018-03-20 14:59:38 PDT 
Comment on attachment 336146 [details]
patch for landing

Clearing flags on attachment: 336146

Committed r229775: <https://trac.webkit.org/changeset/229775>
Comment 6 WebKit Commit Bot 2018-03-20 14:59:39 PDT 
All reviewed patches have been landed.  Closing bug.