Bug 183793 – [JSC] add support for lexing PrivateName productions

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: New Bugs

[Caitlin Potter (:caitp)]

[JSC] add support for lexing PrivateName productions

[Caitlin Potter (:caitp)]

Created attachment 336142 [details]
Patch

[Caitlin Potter (:caitp)]

This is related to https://bugs.webkit.org/show_bug.cgi?id=174212, and adds lexer support for the PrivateName production.

[Caitlin Potter (:caitp)]

Created attachment 336147 [details]
Patch

slightly better error messages in a few places

[EWS Watchlist]

Comment on attachment 336147 [details]
Patch

Attachment 336147 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/7042655

New failing tests:
js/dom/invalid-syntax-for-function.html

[EWS Watchlist]

Created attachment 336153 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 336147 [details]
Patch

Attachment 336147 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/7042808

New failing tests:
js/dom/invalid-syntax-for-function.html

[EWS Watchlist]

Created attachment 336154 [details]
Archive of layout-test-results from ews103 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Caitlin Potter (:caitp)]

Created attachment 336156 [details]
Patch

Fix layout test

[EWS Watchlist]

Comment on attachment 336156 [details]
Patch

Attachment 336156 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/7044000

New failing tests:
js/dom/invalid-syntax-for-function.html

[EWS Watchlist]

Created attachment 336159 [details]
Archive of layout-test-results from ews102 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 336156 [details]
Patch

Attachment 336156 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/7044026

New failing tests:
js/dom/invalid-syntax-for-function.html

[EWS Watchlist]

Created attachment 336161 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 336156 [details]
Patch

Attachment 336156 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/7044037

New failing tests:
js/dom/invalid-syntax-for-function.html

[EWS Watchlist]

Created attachment 336163 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 336156 [details]
Patch

Attachment 336156 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/7044040

New failing tests:
js/dom/invalid-syntax-for-function.html

[EWS Watchlist]

Created attachment 336165 [details]
Archive of layout-test-results from ews115 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 336156 [details]
Patch

Attachment 336156 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7044420

New failing tests:
js/dom/invalid-syntax-for-function.html

[EWS Watchlist]

Created attachment 336166 [details]
Archive of layout-test-results from ews202 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews202  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Caitlin Potter (:caitp)]

Created attachment 336186 [details]
Patch

_actually_ fix the layout test

[Caitlin Potter (:caitp)]

Created attachment 336243 [details]
Patch

simplify a bit

[Caio Lima]

Comment on attachment 336243 [details]
Patch

Patch LGTM. I think you could create some tests for cases where parsing fails. I also think it is good to put it behind a feature flag, since the error message can make the user think that we already support private members.

[Caitlin Potter (:caitp)]

(In reply to Caio Lima from comment #21)
> Comment on attachment 336243 [details]
> Patch
> 
> Patch LGTM. I think you could create some tests for cases where parsing
> fails. I also think it is good to put it behind a feature flag, since the
> error message can make the user think that we already support private
> members.

I think we're going to forego landing this until the class fields work is close to landing, unless port owners are ok with bleeding edge having that error message (which I suspect is not hit often in practice)

[EWS Watchlist]

Comment on attachment 336243 [details]
Patch

Attachment 336243 [details] did not pass jsc-ews (mac):
Output: http://webkit-queues.webkit.org/results/7057267

New failing tests:
stress/ftl-put-by-id-setter-exception-interesting-live-state.js.ftl-eager

[Yusuke Suzuki]

Comment on attachment 336243 [details]
Patch

Private name parsing is already landed.

[Yusuke Suzuki]

*** This bug has been marked as a duplicate of bug 206431 ***