Bug 183781 – [Web Animations] Dispatch DOM events for CSS Transitions and CSS Animations implemented as Web Animations

• Status: RESOLVED
• Resolution: FIXED
• Component: Animations

[Antoine Quint]

Now that we've implemented CSS Animations and CSS Transitions as Web Animations (webkit.org/b/183504) we need to dispatch DOM events for them as well, as specified by https://drafts.csswg.org/css-animations-2/#events and https://drafts.csswg.org/css-transitions-2/#transition-events.

[Antoine Quint]

Created attachment 336135 [details]
Patch

[Dean Jackson]

Comment on attachment 336135 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336135&action=review

This is all good. It just needs to be split into smaller patches because it is doing multiple things.

> Source/WebCore/animation/AnimationTimeline.cpp:148
> +    // In case this element is newly getting a "display: none" we need to cancel all of its animations and disregard new ones.
> +    if (oldStyle && oldStyle->hasAnimations() && oldStyle->display() != NONE && newStyle.display() == NONE) {
> +        if (m_elementToCSSAnimationByName.contains(&element)) {
> +            for (const auto& cssAnimationsByNameMapItem : m_elementToCSSAnimationByName.take(&element))
> +                cancelOrRemoveDeclarativeAnimation(cssAnimationsByNameMapItem.value);
> +        }
> +        return;
> +    }
> +
> +    if (oldStyle && oldStyle->hasAnimations() && newStyle.hasAnimations() && *(oldStyle->animations()) == *(newStyle.animations()))
> +        return;

This display:none work should be a separate patch.

> Source/WebCore/animation/DeclarativeAnimation.cpp:72
> +    else
> +        pause();

So should this.

> Source/WebCore/animation/DeclarativeAnimation.cpp:106
> +void DeclarativeAnimation::cancel()
> +{
> +    auto cancelationTime = 0_s;
> +    if (auto animationEffect = effect())
> +        cancelationTime = animationEffect->activeTime().value_or(0_s);
> +
> +    WebAnimation::cancel();
> +
> +    invalidateDOMEvents(cancelationTime);
> +}

And maybe cancel() on declarative animations should be a separate patch too.

[Antoine Quint]

I will land this as smaller patches.

[Antoine Quint]

Actually, we can reuse this bug.

[Antoine Quint]

Created attachment 336211 [details]
Patch

[Antoine Quint]

Created attachment 336216 [details]
Patch

[Antoine Quint]

Committed r229818: <https://trac.webkit.org/changeset/229818>

[Radar WebKit Bug Importer]

<rdar://problem/38718784>