Bug 183758 - Add and adopt WK_PLATFORM_NAME and adjust default feature defines
Summary: Add and adopt WK_PLATFORM_NAME and adjust default feature defines
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-03-19 18:13 PDT by Tim Horton
Modified: 2018-03-20 11:18 PDT (History)
16 users (show)

See Also:

Attachments
Patch (99.15 KB, patch)
2018-03-19 18:16 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (98.04 KB, patch)
2018-03-19 18:20 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (103.92 KB, patch)
2018-03-19 22:45 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (105.22 KB, patch)
2018-03-20 00:08 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (2.24 MB, application/zip)
2018-03-20 01:58 PDT, EWS Watchlist 		no flags Details
Patch (105.64 KB, patch)
2018-03-20 10:53 PDT, Tim Horton 		mitz: review+
Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2018-03-19 18:13:38 PDT 
Add and adopt WK_PLATFORM_NAME and adjust default feature defines
Comment 1 Tim Horton 2018-03-19 18:16:00 PDT 
Created attachment 336089 [details]
Patch
Comment 2 Tim Horton 2018-03-19 18:16:34 PDT 
<rdar://problem/38017644>
Comment 3 Tim Horton 2018-03-19 18:20:19 PDT 
Created attachment 336092 [details]
Patch
Comment 4 mitz 2018-03-19 19:14:38 PDT 
Comment on attachment 336092 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336092&action=review

> Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:38
> +WK_PLATFORM_NAME = $(WK_PLATFORM_NAME_USE_ALTERNATE_FRAMEWORKS_DIR_$(WK_USE_ALTERNATE_FRAMEWORKS_DIR));
> +WK_PLATFORM_NAME_USE_ALTERNATE_FRAMEWORKS_DIR_YES = iphoneminimalsimulator;
> +WK_PLATFORM_NAME_USE_ALTERNATE_FRAMEWORKS_DIR_NO = $(PLATFORM_NAME);

Seems like this could go into the Base.xcconfigs.
Comment 5 Tim Horton 2018-03-19 19:59:09 PDT 
Whoops, yes, that’s totally where it belongs.
Comment 6 Tim Horton 2018-03-19 22:45:47 PDT 
Created attachment 336104 [details]
Patch
Comment 7 EWS Watchlist 2018-03-19 22:47:11 PDT 
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Comment 8 Tim Horton 2018-03-20 00:08:47 PDT 
Created attachment 336106 [details]
Patch
Comment 9 EWS Watchlist 2018-03-20 01:57:59 PDT 
Comment on attachment 336106 [details]
Patch

Attachment 336106 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/7035873

New failing tests:
fast/dom/DeviceMotion/create-event.html
imported/w3c/web-platform-tests/dom/events/EventTarget-dispatchEvent.html
fast/dom/DeviceMotion/optional-event-properties.html
Comment 10 EWS Watchlist 2018-03-20 01:58:01 PDT 
Created attachment 336110 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6
Comment 11 Tim Horton 2018-03-20 10:53:51 PDT 
Created attachment 336133 [details]
Patch
Comment 12 mitz 2018-03-20 11:00:28 PDT 
Comment on attachment 336133 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336133&action=review

> Source/WTF/wtf/FeatureDefines.h:236
> +#if ENABLE(MINIMAL_SIMULATOR)
> +
> +#if !defined(ENABLE_LEGACY_ENCRYPTED_MEDIA)
> +#define ENABLE_LEGACY_ENCRYPTED_MEDIA 0
> +#endif
> +
> +#endif /* ENABLE(MINIMAL_SIMULATOR) */

Makes more sense to move this into the #if !defined(ENABLE_LEGACY_ENCRYPTED_MEDIA) below.
Comment 13 Tim Horton 2018-03-20 11:18:52 PDT 
https://trac.webkit.org/changeset/229768/webkit