RESOLVED FIXED 183753
Have select element respect current appearance 
https://bugs.webkit.org/show_bug.cgi?id=183753
Summary Have select element respect current appearance
Megan Gardner
Reported 2018-03-19 15:00:28 PDT
Have select element respect current appearance
Attachments
Patch (1.66 KB, patch)
2018-03-19 17:59 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (1.69 KB, patch)
2018-03-19 18:12 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (1.74 KB, patch)
2018-03-19 18:17 PDT, Megan Gardner 		thorton: review+
thorton: commit-queue+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Megan Gardner
Comment 1 2018-03-19 17:59:49 PDT
Created attachment 336087 [details] Patch
Radar WebKit Bug Importer
Comment 2 2018-03-19 18:01:02 PDT
<rdar://problem/38644433>
Tim Horton
Comment 3 2018-03-19 18:04:06 PDT
Comment on attachment 336087 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336087&action=review > Source/WebCore/rendering/RenderThemeMac.mm:1348 > + style.setColor(e ? !e->isDisabledFormControl() ? systemColor(CSSValueButtontext, e->document().page()->useSystemAppearance()) : systemColor(CSSValueGraytext, e->document().page()->useSystemAppearance()) : Color::darkGray); The logic here (nested ternary operators) is incredibly hard to follow. Can we pop it out into a few lines instead?
Tim Horton
Comment 4 2018-03-19 18:04:37 PDT
Also I can't actually follow if you don't dereference e in the !e case
Megan Gardner
Comment 5 2018-03-19 18:12:05 PDT
Created attachment 336088 [details] Patch
Tim Horton
Comment 6 2018-03-19 18:15:16 PDT
Comment on attachment 336088 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336088&action=review > Source/WebCore/rendering/RenderThemeMac.mm:1350 > + c = !e->isDisabledFormControl() ? systemColor(CSSValueButtontext, e->document().page()->useSystemAppearance()) : systemColor(CSSValueGraytext, e->document().page()->useSystemAppearance()); Pop useSystemAppearance into a local
Megan Gardner
Comment 7 2018-03-19 18:17:17 PDT
Created attachment 336090 [details] Patch
Megan Gardner
Comment 8 2018-03-19 18:22:52 PDT
https://trac.webkit.org/changeset/229730/webkit
Ryan Haddad
Comment 9 2018-03-20 09:26:35 PDT
Rebaselined failing tests in https://trac.webkit.org/changeset/229762/webkit
Note You need to log in before you can comment on or make changes to this bug.