Bug 183751 - AX: embedded attachments do not work correctly with text marker APIs on macOS
Summary: AX: embedded attachments do not work correctly with text marker APIs on macOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-03-19 14:32 PDT by Nan Wang
Modified: 2018-03-19 18:08 PDT (History)
11 users (show)

See Also:

Attachments
patch (3.14 KB, patch)
2018-03-19 14:56 PDT, Nan Wang 		no flags Details | Formatted Diff | Diff
patch (3.14 KB, patch)
2018-03-19 15:21 PDT, Nan Wang 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nan Wang 2018-03-19 14:32:27 PDT 
AXUnknown is returned in AXAttributedStringForTextMarkerRange and AXUIElementForTextMarker when there's an embedded attachment.

<rdar://problem/37709113>
Comment 1 Nan Wang 2018-03-19 14:56:23 PDT 
Created attachment 336076 [details]
patch
Comment 2 chris fleizach 2018-03-19 15:14:25 PDT 
Comment on attachment 336076 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336076&action=review

> Source/WebCore/ChangeLog:8
> +        In WebKit1, embeddd attachments are not working well with text marker APIs.

embedded

> Source/WebCore/ChangeLog:10
> +        1. Hittesting on an attachment object.

hit testing
Comment 3 Nan Wang 2018-03-19 15:21:31 PDT 
Created attachment 336077 [details]
patch

update
Comment 4 WebKit Commit Bot 2018-03-19 18:08:57 PDT 
Comment on attachment 336077 [details]
patch

Clearing flags on attachment: 336077

Committed r229729: <https://trac.webkit.org/changeset/229729>
Comment 5 WebKit Commit Bot 2018-03-19 18:08:58 PDT 
All reviewed patches have been landed.  Closing bug.