Bug 183736 – Investigate why __cpu_indicator_init is used

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Yusuke Suzuki]

It calls static initializer. If it is possible, dropping it would be nice.

This is happening because we’re passing -all_load to the linker when linking JavaScriptCore, which prevents the linker from eliding __cpu_indicator_init even though it’s unused.

We should probably switch to -force_load for whichever libraries we need.

Also, reexporting libobjc is probably a mistake, introduced in <https://trac.webkit.org/r6086>.

The -all_load was added in <https://trac.webkit.org/r111786> to fix the build after <https://trac.webkit.org/r111778>, but really could have just been -force_load WTF (if all supported linkers had that option at the time).

We might not even need to -force_load WTF (which is tricky, because it requires a configuration-dependent path), if -ObjC is sufficient.

Created attachment 336033 [details]
WIP

Created attachment 336043 [details]
WIP

Created attachment 336085 [details]
Stop using -all_load

[WebKit Commit Bot]

Comment on attachment 336085 [details]
Stop using -all_load

Clearing flags on attachment: 336085

Committed r229738: <https://trac.webkit.org/changeset/229738>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/38648167>

[Darin Adler]

Is there some alternative to doing force load for the entire WTF library that would be an even better solution long term?

(In reply to Darin Adler from comment #12)
> Is there some alternative to doing force load for the entire WTF library
> that would be an even better solution long term?

Not loading all of WTF can only be an improvement if we believe that WTF includes or might include unused code. However, I don’t think there’s a good way to predict, when building JavaScriptCore, which parts of WTF that aren’t used in JSC are needed by WebCore and WebKit. If we just add those parts to a list in JavaScriptCore, we’ll have an easy way to add to the list (add something if Web* fails to build without it) but no good way to remove from it.