Bug 183725 – REGRESSION (r222113): Tests fail in messages_unittest.py

• Status: ASSIGNED
• Component: Tools / Tests

[Daniel Bates]

Steps to reproduce:

1. Open a terminal and change directories to the top-level WebKit checkout.
2. Run `python Source/WebKit/Scripts/webkit/messages_unittest.py`

Then the unit tests fail:

$ python Source/WebKit/Scripts/webkit/messages_unittest.py
F....
======================================================================
FAIL: test_receiver_headers (__main__.HeaderTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "Source/WebKit/Scripts/webkit/messages_unittest.py", line 328, in test_receiver_headers
    _expected_receiver_header_file_name)
  File "Source/WebKit/Scripts/webkit/messages_unittest.py", line 318, in assertHeaderEqual
    self.assertGeneratedFileContentsEqual(actual_file_contents, expected_file_name)
  File "Source/WebKit/Scripts/webkit/messages_unittest.py", line 312, in assertGeneratedFileContentsEqual
    self.assertEquals(actual_line, expected_line_list[index])
AssertionError: '#include <wtf/HashMap.h>' != '#include <wtf/Forward.h>'

----------------------------------------------------------------------
Ran 5 tests in 0.012s

FAILED (failures=1)

[Daniel Bates]

Created attachment 336014 [details]
Patch

[Daniel Bates]

The test failures were caused by the patch for bug #176984. We need to make the messages generator smarter in order for the expected results to use the wtf/Forward.h header instead of wtf/Vector.h.

[Daniel Bates]

Committed in <https://trac.webkit.org/changeset/229697>.