Bug 183718 - RenderTreeNeedsLayoutChecker fails with absolutely positioned svg and <use>
Summary: RenderTreeNeedsLayoutChecker fails with absolutely positioned svg and <use>
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks: 183572
  Show dependency tree / graph
 
Reported: 2018-03-16 20:12 PDT by zalan
Modified: 2018-03-20 18:32 PDT (History)
4 users (show)

See Also:

Attachments
Test reduction (495 bytes, text/html)
2018-03-16 20:12 PDT, zalan 		no flags Details
Patch (7.64 KB, patch)
2018-03-20 14:32 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (7.69 KB, patch)
2018-03-20 15:15 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (7.72 KB, patch)
2018-03-20 15:53 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-03-16 20:12:28 PDT 
Created attachment 335992 [details]
Test reduction

ssia.
Comment 1 zalan 2018-03-20 14:32:34 PDT 
Created attachment 336151 [details]
Patch
Comment 2 Antti Koivisto 2018-03-20 14:39:51 PDT 
Comment on attachment 336151 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336151&action=review

> Source/WebCore/css/StyleResolver.cpp:816
> +    if (svgElement.hasTagName(SVGNames::svgTag) && (!svgElement.parentNode() || svgElement.parentNode()->isSVGElement() || svgElement.correspondingElement()))

The original test is

if (!(element->hasTagName(SVGNames::svgTag) && element->parentNode() && !element->parentNode()->isSVGElement()))

This doesn't seem like the same.
Comment 3 zalan 2018-03-20 15:15:59 PDT 
Created attachment 336158 [details]
Patch
Comment 4 zalan 2018-03-20 15:53:48 PDT 
Created attachment 336160 [details]
Patch
Comment 5 WebKit Commit Bot 2018-03-20 18:31:14 PDT 
Comment on attachment 336160 [details]
Patch

Clearing flags on attachment: 336160

Committed r229782: <https://trac.webkit.org/changeset/229782>
Comment 6 WebKit Commit Bot 2018-03-20 18:31:16 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-03-20 18:32:27 PDT 
<rdar://problem/38689390>