Bug 183709 – Ensure Document::responseReceived and clearResource are called on the main thread

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[youenn fablet]

Ensure Document::responseReceived and clearResource are called on the main thread
This might help debugging rdar://problem/36256931

[youenn fablet]

Created attachment 335974 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 335974 [details]
Patch

Clearing flags on attachment: 335974

Committed r229690: <https://trac.webkit.org/changeset/229690>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/38566063>

[Alexey Proskuryakov]

Comment on attachment 335974 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335974&action=review

> Source/WebCore/loader/DocumentLoader.cpp:704
> +    ASSERT(isMainThread());

I don't think that this qualifies as "ensure". "Try to find cases when not", maybe.

[Chris Dumez]

(In reply to Alexey Proskuryakov from comment #5)
> Comment on attachment 335974 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=335974&action=review
> 
> > Source/WebCore/loader/DocumentLoader.cpp:704
> > +    ASSERT(isMainThread());
> 
> I don't think that this qualifies as "ensure". "Try to find cases when not",
> maybe.

... or are we ensuring by crashing otherwise?

[Alexey Proskuryakov]

That's only in debug mode.