Bug 183709 - Ensure Document::responseReceived and clearResource are called on the main thread
Summary: Ensure Document::responseReceived and clearResource are called on the main th...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-03-16 15:01 PDT by youenn fablet
Modified: 2018-03-19 12:48 PDT (History)
12 users (show)

See Also:

Attachments
Patch (1.70 KB, patch)
2018-03-16 15:02 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2018-03-16 15:01:02 PDT 
Ensure Document::responseReceived and clearResource are called on the main thread
This might help debugging rdar://problem/36256931
Comment 1 youenn fablet 2018-03-16 15:02:12 PDT 
Created attachment 335974 [details]
Patch
Comment 2 WebKit Commit Bot 2018-03-16 17:39:50 PDT 
Comment on attachment 335974 [details]
Patch

Clearing flags on attachment: 335974

Committed r229690: <https://trac.webkit.org/changeset/229690>
Comment 3 WebKit Commit Bot 2018-03-16 17:39:51 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2018-03-16 17:41:24 PDT 
<rdar://problem/38566063>
Comment 5 Alexey Proskuryakov 2018-03-19 09:32:17 PDT 
Comment on attachment 335974 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335974&action=review

> Source/WebCore/loader/DocumentLoader.cpp:704
> +    ASSERT(isMainThread());

I don't think that this qualifies as "ensure". "Try to find cases when not", maybe.
Comment 6 Chris Dumez 2018-03-19 09:34:12 PDT 
(In reply to Alexey Proskuryakov from comment #5)
> Comment on attachment 335974 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=335974&action=review
> 
> > Source/WebCore/loader/DocumentLoader.cpp:704
> > +    ASSERT(isMainThread());
> 
> I don't think that this qualifies as "ensure". "Try to find cases when not",
> maybe.

... or are we ensuring by crashing otherwise?
Comment 7 Alexey Proskuryakov 2018-03-19 12:48:05 PDT 
That's only in debug mode.