Bug 183701 - Make run-webkit-app work for non-GUI apps
Summary: Make run-webkit-app work for non-GUI apps
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Mac All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-03-16 10:25 PDT by Daniel Bates
Modified: 2018-03-19 13:50 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.34 KB, patch)
2018-03-16 10:50 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
Patch (2.34 KB, patch)
2018-03-16 11:24 PDT, Daniel Bates 		lforschler: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2018-03-16 10:25:05 PDT 
The run-webkit-app is convenient for running a GUI app with a built WebKit. I do not see a need to restrict this functionality to GUI apps. We should also make run-webkit-app work for non-GUI apps.
Comment 1 Daniel Bates 2018-03-16 10:50:26 PDT 
Created attachment 335951 [details]
Patch
Comment 2 Daniel Bates 2018-03-16 11:24:06 PDT 
Created attachment 335954 [details]
Patch
Comment 3 Daniel Bates 2018-03-19 11:39:45 PDT 
Comment on attachment 335954 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335954&action=review

> Tools/Scripts/webkitdirs.pm:97
>         USE_OPEN_COMMAND
> +       DO_NOT_USE_OPEN_COMMAND

I'll sort these before landing.
Comment 4 Daniel Bates 2018-03-19 13:49:17 PDT 
Committed r229711: <https://trac.webkit.org/changeset/229711>
Comment 5 Radar WebKit Bug Importer 2018-03-19 13:50:36 PDT 
<rdar://problem/38633433>