Bug 183686 – [Curl] Fix crash on websocket with bad handshake message.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Basuke Suzuki]

It was found by this existing test LayoutTests\http\tests\websocket\tests\hybi\bad-handshake-crash.html.

[Basuke Suzuki]

Created attachment 335913 [details]
PATCH

[youenn fablet]

Comment on attachment 335913 [details]
PATCH

View in context: https://bugs.webkit.org/attachment.cgi?id=335913&action=review

> Source/WebCore/platform/network/curl/SocketStreamHandleImplCurl.cpp:94
> +    m_closed = true;

In case platformClose() needs to be called elsewhere in the future, we could rewrite it as:
if (m_closed)
     return;
m_closed = true;
...

[Basuke Suzuki]

(In reply to youenn fablet from comment #2)
> Comment on attachment 335913 [details]
> PATCH
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=335913&action=review
> 
> > Source/WebCore/platform/network/curl/SocketStreamHandleImplCurl.cpp:94
> > +    m_closed = true;
> 
> In case platformClose() needs to be called elsewhere in the future, we could
> rewrite it as:
> if (m_closed)
>      return;
> m_closed = true;
> ...

Right. There're many other crashes to be fixed following this bug. Such kind of protection may be required. Thanks for pointing out.

[Basuke Suzuki]

Created attachment 335948 [details]
FIX

Thanks for r+ @youenn

[WebKit Commit Bot]

Comment on attachment 335948 [details]
FIX

Clearing flags on attachment: 335948

Committed r229681: <https://trac.webkit.org/changeset/229681>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/38557767>