Bug 183679 - WebKit.RestoreSessionStateContainingScrollRestorationDefault API test is failing with async policy delegates
Summary: WebKit.RestoreSessionStateContainingScrollRestorationDefault API test is fail...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 180568
  Show dependency tree / graph
 
Reported: 2018-03-15 14:45 PDT by Chris Dumez
Modified: 2018-03-16 11:34 PDT (History)
4 users (show)

See Also:

Attachments
Patch (22.32 KB, patch)
2018-03-15 15:06 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (22.28 KB, patch)
2018-03-15 16:45 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (22.29 KB, patch)
2018-03-16 08:51 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (24.08 KB, patch)
2018-03-16 09:54 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2018-03-15 14:45:59 PDT 
WebKit.RestoreSessionStateContainingScrollRestorationDefault API test is failing with async policy delegates.
Comment 1 Chris Dumez 2018-03-15 15:06:03 PDT 
Created attachment 335890 [details]
Patch
Comment 2 Chris Dumez 2018-03-15 16:45:57 PDT 
Created attachment 335910 [details]
Patch
Comment 3 Alex Christensen 2018-03-16 08:28:51 PDT 
Comment on attachment 335910 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335910&action=review

> Source/WebCore/loader/cache/CachedRawResource.cpp:161
> +        auto responseProcessedHandler = [this, protectedThis = CachedResourceHandle<CachedRawResource>(this), client] {

To make MSVC happy, replace "protectedThis = CachedResourceHandle<CachedRawResource>(this)" with "protectedThis = WTFMove(protectedThis)".  MSVC thinks "this" refers to the containing lambda sometimes.
Comment 4 Chris Dumez 2018-03-16 08:51:22 PDT 
Created attachment 335939 [details]
Patch
Comment 5 Chris Dumez 2018-03-16 09:54:32 PDT 
Created attachment 335945 [details]
Patch
Comment 6 Chris Dumez 2018-03-16 11:33:53 PDT 
Comment on attachment 335945 [details]
Patch

Clearing flags on attachment: 335945

Committed r229675: <https://trac.webkit.org/changeset/229675>
Comment 7 Chris Dumez 2018-03-16 11:33:54 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2018-03-16 11:34:24 PDT 
<rdar://problem/38552016>