Bug 183675 - Add and adopt WK_ALTERNATE_FRAMEWORKS_DIR in ANGLE
Summary: Add and adopt WK_ALTERNATE_FRAMEWORKS_DIR in ANGLE
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-03-15 14:01 PDT by Tim Horton
Modified: 2018-03-15 15:43 PDT (History)
13 users (show)

See Also:


Attachments
Patch (5.29 KB, patch)
2018-03-15 14:03 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
Patch (5.29 KB, patch)
2018-03-15 15:06 PDT, Tim Horton
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2018-03-15 14:01:36 PDT
Add and adopt WK_ALTERNATE_FRAMEWORKS_DIR in ANGLE
Comment 1 Radar WebKit Bug Importer 2018-03-15 14:03:20 PDT
<rdar://problem/38515281>
Comment 2 Tim Horton 2018-03-15 14:03:49 PDT
Created attachment 335879 [details]
Patch
Comment 3 EWS Watchlist 2018-03-15 14:07:08 PDT
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Comment 4 mitz 2018-03-15 15:01:22 PDT
Comment on attachment 335879 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335879&action=review

> Source/ThirdParty/ANGLE/Configurations/Base.xcconfig:76
> +ANGLE_INSTALL_PATH_PREFIX_YES = $(WK_ALTERNATE_FRAMEWORKS_DIR)/;

Why the trailing / here? You seem to not need it in all use sites.
Comment 5 Tim Horton 2018-03-15 15:06:31 PDT
Created attachment 335891 [details]
Patch
Comment 6 WebKit Commit Bot 2018-03-15 15:43:06 PDT
Comment on attachment 335891 [details]
Patch

Clearing flags on attachment: 335891

Committed r229646: <https://trac.webkit.org/changeset/229646>
Comment 7 WebKit Commit Bot 2018-03-15 15:43:08 PDT
All reviewed patches have been landed.  Closing bug.