Flash content broke after r229484 because it needs an active CGSConnection to perform certain drawing operations. To maintain compatibility, we need to continue to allow the Plugin Process to communicate with the Window Server, which is unfortunate.
<rdar://problem/38439218>
Created attachment 335857 [details] Patch
Comment on attachment 335857 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=335857&action=review > Source/WebKit/Platform/mac/LayerHostingContext.mm:81 > + layerHostingContext->m_context = [CAContext contextWithCGSConnection:CGSMainConnectionID() options:@{ kCAContextCIFilterBehavior : @"ignore" }]; Will creating the context with 'layerHostingContext->m_context = [CAContext remoteContextWithOptions:@{kCAContextCIFilterBehavior : @"ignore"}];' work?
(In reply to Per Arne Vollan from comment #3) > Comment on attachment 335857 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=335857&action=review > > > Source/WebKit/Platform/mac/LayerHostingContext.mm:81 > > + layerHostingContext->m_context = [CAContext contextWithCGSConnection:CGSMainConnectionID() options:@{ kCAContextCIFilterBehavior : @"ignore" }]; > > Will creating the context with 'layerHostingContext->m_context = [CAContext > remoteContextWithOptions:@{kCAContextCIFilterBehavior : @"ignore"}];' work? No -- I tried that first and it failed.
Comment on attachment 335857 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=335857&action=review R=me. >>> Source/WebKit/Platform/mac/LayerHostingContext.mm:81 >>> + layerHostingContext->m_context = [CAContext contextWithCGSConnection:CGSMainConnectionID() options:@{ kCAContextCIFilterBehavior : @"ignore" }]; >> >> Will creating the context with 'layerHostingContext->m_context = [CAContext remoteContextWithOptions:@{kCAContextCIFilterBehavior : @"ignore"}];' work? > > No -- I tried that first and it failed. Ah, right. I first thought it was the call '[CAContext setAllowsCGSConnections:NO];' that made this fail for the Plugin process.
Comment on attachment 335857 [details] Patch Clearing flags on attachment: 335857 Committed r229629: <https://trac.webkit.org/changeset/229629>
All reviewed patches have been landed. Closing bug.