Bug 183649 – Add and adopt WK_ALTERNATE_FRAMEWORKS_DIR in JavaScriptCore

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tim Horton]

Add and adopt WK_ALTERNATE_FRAMEWORKS_DIR in JavaScriptCore

[Radar WebKit Bug Importer]

<rdar://problem/38480526>

[Tim Horton]

Created attachment 335821 [details]
Patch

Comment on attachment 335821 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335821&action=review

r=me but prefer the minimalistic version

> Source/JavaScriptCore/Configurations/Base.xcconfig:94
> +HEADER_SEARCH_PATHS = . "${BUILT_PRODUCTS_DIR}${WK_ALTERNATE_WEBKIT_SDK_PATH}/usr/local/include" $(HEADER_SEARCH_PATHS);

Good opportunity to change that trailing $(HEADER_SEARCH_PATHS) to $(inherited)

> Source/JavaScriptCore/Configurations/Base.xcconfig:95
> +SYSTEM_HEADER_SEARCH_PATHS = $(SDK_DIR)$(WK_ALTERNATE_WEBKIT_SDK_PATH)/usr/local/include $(inherited);

I think this might not be needed—anytime WK_ALTERNATE_WEBKIT_SDK_PATH is set, something external to the project is going to include this in SYSTEM_HEADER_SEARCH_PATHS.

> Source/JavaScriptCore/Configurations/Base.xcconfig:96
> +LIBRARY_SEARCH_PATHS = $(SDK_DIR)$(WK_ALTERNATE_WEBKIT_SDK_PATH)/usr/local/lib $(inherited);

Ditto.

[EWS Watchlist]

Comment on attachment 335821 [details]
Patch

Attachment 335821 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/6959601

New failing tests:
http/tests/preload/download_resources.html

[EWS Watchlist]

Created attachment 335826 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Tim Horton]

https://trac.webkit.org/changeset/229637/webkit