Bug 183646 - AX: Add Experimental setting for Accessibility Audit
Summary: AX: Add Experimental setting for Accessibility Audit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: Safari 11
Hardware: All All
: P2 Normal
Assignee: Aaron Chu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-03-14 16:14 PDT by Aaron Chu
Modified: 2018-04-03 17:46 PDT (History)
6 users (show)

See Also:


Attachments
Patch (4.66 KB, patch)
2018-03-15 16:27 PDT, Aaron Chu
no flags Details | Formatted Diff | Diff
Patch (4.68 KB, patch)
2018-04-03 00:59 PDT, Aaron Chu
no flags Details | Formatted Diff | Diff
Patch (4.68 KB, patch)
2018-04-03 17:05 PDT, Aaron Chu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aaron Chu 2018-03-14 16:14:45 PDT
Add experimental setting for Accessibility Audit.
Comment 1 Radar WebKit Bug Importer 2018-03-14 16:15:00 PDT
<rdar://problem/38478583>
Comment 2 Aaron Chu 2018-03-15 16:27:15 PDT
Created attachment 335908 [details]
Patch
Comment 3 BJ Burg 2018-04-02 17:44:49 PDT
Comment on attachment 335908 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335908&action=review

r=me. Please fix typo before landing, or re-upload with fix and set cq? flag.

> Source/WebInspectorUI/UserInterface/Base/Setting.js:131
> +    experimentalEnableAccessibilityAuditTab: new WI.Setting("experimental-enable-accessibiilty-audit-tab", false),

Typo: accessibility
Comment 4 Aaron Chu 2018-04-03 00:59:18 PDT
Created attachment 337064 [details]
Patch
Comment 5 EWS Watchlist 2018-04-03 01:54:48 PDT
Comment on attachment 337064 [details]
Patch

Rejecting attachment 337064 [details] from commit-queue.

aaron_chu@apple.com does not have committer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 6 Aaron Chu 2018-04-03 17:05:30 PDT
Created attachment 337133 [details]
Patch
Comment 7 WebKit Commit Bot 2018-04-03 17:46:55 PDT
Comment on attachment 337133 [details]
Patch

Clearing flags on attachment: 337133

Committed r230228: <https://trac.webkit.org/changeset/230228>
Comment 8 WebKit Commit Bot 2018-04-03 17:46:56 PDT
All reviewed patches have been landed.  Closing bug.