https://bugs.webkit.org/show_bug.cgi?id=182218 added support to submit build request to Buildbot 0.9 server using HTTP POST request. However the parameters which are of Boolean type (indicating by checkbox) are not set. This is because of the difference between Buildbot 0.8 and 0.9. Earlier we were setting these properties as: checkbox: 'test-webkit'. Now it should be set as: 'test-webkit': true buildbot-syncer.js should allow boolean properties as well.
Created attachment 335780 [details] Proposed patch
This change looks good to me. The only concern is whether we should keep both test cases for buildbot 0.8 and 0.9.
Created attachment 335785 [details] Updated patch Updated patch with Ryosuke's in-person feedback incorporated.
Comment on attachment 335785 [details] Updated patch Clearing flags on attachment: 335785 Committed r229618: <https://trac.webkit.org/changeset/229618>
All reviewed patches have been landed. Closing bug.
<rdar://problem/38486015>