Bug 183623 - Enhance the MacroAssembler and LinkBuffer to support pointer profiling.
Summary: Enhance the MacroAssembler and LinkBuffer to support pointer profiling.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
: 183622 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-03-13 19:37 PDT by Mark Lam
Modified: 2019-11-12 14:22 PST (History)
8 users (show)

See Also:

Attachments
proposed patch. (157.06 KB, patch)
2018-03-13 19:46 PDT, Mark Lam 		msaboff: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2018-03-13 19:37:07 PDT 
Patch coming.
Comment 1 Radar WebKit Bug Importer 2018-03-13 19:37:34 PDT 
<rdar://problem/38443314>
Comment 2 Mark Lam 2018-03-13 19:46:14 PDT 
Created attachment 335755 [details]
proposed patch.
Comment 3 EWS Watchlist 2018-03-13 19:48:05 PDT 
Attachment 335755 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/assembler/LinkBuffer.h:321:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/assembler/LinkBuffer.h:326:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/assembler/LinkBuffer.h:330:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/assembler/LinkBuffer.h:345:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/assembler/LinkBuffer.h:348:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
Total errors found: 5 in 70 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Michael Saboff 2018-03-14 10:55:12 PDT 
Comment on attachment 335755 [details]
proposed patch.

r=me
Comment 5 Mark Lam 2018-03-14 13:06:27 PDT 
Thanks for the review.  Landed in r229609: <http://trac.webkit.org/r229609>.
Comment 6 Robin Morisset 2019-11-12 14:22:29 PST 
*** Bug 183622 has been marked as a duplicate of this bug. ***