RESOLVED FIXED 183623
Enhance the MacroAssembler and LinkBuffer to support pointer profiling.
https://bugs.webkit.org/show_bug.cgi?id=183623
Summary Enhance the MacroAssembler and LinkBuffer to support pointer profiling.
Mark Lam
Reported 2018-03-13 19:37:07 PDT
Patch coming.
Attachments
proposed patch. (157.06 KB, patch)
2018-03-13 19:46 PDT, Mark Lam
msaboff: review+
Radar WebKit Bug Importer
Comment 1 2018-03-13 19:37:34 PDT
Mark Lam
Comment 2 2018-03-13 19:46:14 PDT
Created attachment 335755 [details] proposed patch.
EWS Watchlist
Comment 3 2018-03-13 19:48:05 PDT
Attachment 335755 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/assembler/LinkBuffer.h:321: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/assembler/LinkBuffer.h:326: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/assembler/LinkBuffer.h:330: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/assembler/LinkBuffer.h:345: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/assembler/LinkBuffer.h:348: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] Total errors found: 5 in 70 files If any of these errors are false positives, please file a bug against check-webkit-style.
Michael Saboff
Comment 4 2018-03-14 10:55:12 PDT
Comment on attachment 335755 [details] proposed patch. r=me
Mark Lam
Comment 5 2018-03-14 13:06:27 PDT
Thanks for the review. Landed in r229609: <http://trac.webkit.org/r229609>.
Robin Morisset
Comment 6 2019-11-12 14:22:29 PST
*** Bug 183622 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.