Otherwise we might end up with a null backend
Created attachment 335743 [details] Patch
Comment on attachment 335743 [details] Patch Attachment 335743 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/6943208 New failing tests: imported/w3c/web-platform-tests/webrtc/RTCConfiguration-iceServers.html imported/w3c/web-platform-tests/webrtc/rtcpeerconnection/rtcpeerconnection-constructor.html fast/mediastream/RTCPeerConnection.html
Created attachment 335751 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 335743 [details] Patch Attachment 335743 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/6945283 New failing tests: imported/w3c/web-platform-tests/webrtc/RTCConfiguration-iceServers.html imported/w3c/web-platform-tests/webrtc/rtcpeerconnection/rtcpeerconnection-constructor.html fast/mediastream/RTCPeerConnection.html
Created attachment 335758 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 335743 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=335743&action=review > Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:337 > + return Exception { TypeError }; Please provide an exception message.
Created attachment 335854 [details] Patch
Comment on attachment 335854 [details] Patch Attachment 335854 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/6966664 New failing tests: fast/mediastream/RTCPeerConnection-getConfiguration.html fast/scrolling/scroll-to-focused-element-asynchronously.html fast/mediastream/RTCPeerConnection.html
Created attachment 335866 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Created attachment 335868 [details] Patch
Created attachment 335873 [details] Patch
Comment on attachment 335873 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=335873&action=review > Source/WebCore/ChangeLog:9 > + Throw an error whenever underlying libwebrtc set configuration is failing. Nit: "is failing" => "fails" > Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:307 > + return Exception { InvalidModificationError, "IceTransportPolicy do not match" }; Nit: something like "IceTransportPolicy does not match existing policy" would be better. > Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:310 > + return Exception { InvalidModificationError, "IceTransportPolicy do not match" }; Nit: something like "IceTransportPolicy pool size does not match existing pool size" would be better.
Created attachment 335886 [details] Patch for landing
Comment on attachment 335886 [details] Patch for landing Clearing flags on attachment: 335886 Committed r229645: <https://trac.webkit.org/changeset/229645>
All reviewed patches have been landed. Closing bug.
<rdar://problem/38520374>