Bug 183607 - WKSystemPreviewView needs to implement some of UIScrollViewDelegate
Summary: WKSystemPreviewView needs to implement some of UIScrollViewDelegate
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-03-13 12:50 PDT by Dean Jackson
Modified: 2018-03-13 13:11 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.40 KB, patch)
2018-03-13 12:51 PDT, Dean Jackson
graouts: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2018-03-13 12:50:10 PDT
WKSystemPreviewView needs to implement some of UIScrollViewDelegate
Comment 1 Radar WebKit Bug Importer 2018-03-13 12:51:04 PDT
<rdar://problem/38427622>
Comment 2 Dean Jackson 2018-03-13 12:51:51 PDT
Created attachment 335716 [details]
Patch
Comment 3 Antoine Quint 2018-03-13 13:05:24 PDT
Comment on attachment 335716 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335716&action=review

> Source/WebKit/UIProcess/ios/WKSystemPreviewView.mm:166
> +// FIXME: This class, and WKWebContentProvider itself, shouldn't need to be a UIScrollViewDelegate.

A bug number would be good here.
Comment 4 Dean Jackson 2018-03-13 13:11:15 PDT
Committed r229583: <https://trac.webkit.org/changeset/229583>