Bug 183600 – Have one service worker process per security origin

• Status: RESOLVED
• Resolution: FIXED
• Component: Service Workers

[Chris Dumez]

Have one service worker process per security origin for security reasons.

[Chris Dumez]

<rdar://problem/35280128>

[Chris Dumez]

Created attachment 335784 [details]
WIP patch

[EWS Watchlist]

Attachment 335784 [details] did not pass style-queue:


ERROR: Source/WebKit/UIProcess/ServiceWorkerProcessProxy.cpp:54:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 24 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EWS Watchlist]

Comment on attachment 335784 [details]
WIP patch

Attachment 335784 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/6953741

New failing tests:
http/tests/workers/service/postmessage-after-sw-process-crash.https.html

[EWS Watchlist]

Created attachment 335792 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[Chris Dumez]

Created attachment 335806 [details]
WIP patch

[EWS Watchlist]

Attachment 335806 [details] did not pass style-queue:


ERROR: Source/WebKit/UIProcess/ServiceWorkerProcessProxy.cpp:54:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 24 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Chris Dumez]

Created attachment 335808 [details]
WIP patch

[EWS Watchlist]

Attachment 335808 [details] did not pass style-queue:


ERROR: Source/WebKit/UIProcess/ServiceWorkerProcessProxy.cpp:54:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 24 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Chris Dumez]

Created attachment 335810 [details]
WIP patch

[EWS Watchlist]

Attachment 335810 [details] did not pass style-queue:


ERROR: Source/WebKit/UIProcess/ServiceWorkerProcessProxy.cpp:54:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 24 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Chris Dumez]

Created attachment 335876 [details]
WIP patch

[EWS Watchlist]

Attachment 335876 [details] did not pass style-queue:


ERROR: Source/WebKit/UIProcess/ServiceWorkerProcessProxy.cpp:54:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 25 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Chris Dumez]

Created attachment 335940 [details]
Patch

[EWS Watchlist]

Attachment 335940 [details] did not pass style-queue:


ERROR: Source/WebKit/UIProcess/ServiceWorkerProcessProxy.cpp:54:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 27 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Chris Dumez]

Created attachment 335941 [details]
Patch

[EWS Watchlist]

Attachment 335941 [details] did not pass style-queue:


ERROR: Source/WebKit/UIProcess/ServiceWorkerProcessProxy.cpp:54:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 27 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Chris Dumez]

Created attachment 335958 [details]
Patch

[EWS Watchlist]

Attachment 335958 [details] did not pass style-queue:


ERROR: Source/WebKit/UIProcess/ServiceWorkerProcessProxy.cpp:54:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 27 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Chris Dumez]

Patch is ready for review.

[Brady Eidson]

Comment on attachment 335958 [details]
Patch

I think we should be able to API test this?

[Chris Dumez]

(In reply to Brady Eidson from comment #21)
> Comment on attachment 335958 [details]
> Patch
> 
> I think we should be able to API test this?

As discussed offline, you are probably right and I'll look into adding such test shortly.

[Chris Dumez]

Created attachment 336074 [details]
Patch

[Chris Dumez]

Comment on attachment 336074 [details]
Patch

Now with an API test.

[EWS Watchlist]

Attachment 336074 [details] did not pass style-queue:


ERROR: Source/WebKit/UIProcess/ServiceWorkerProcessProxy.cpp:54:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 30 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Chris Dumez]

Created attachment 336075 [details]
Patch

[EWS Watchlist]

Attachment 336075 [details] did not pass style-queue:


ERROR: Source/WebKit/UIProcess/ServiceWorkerProcessProxy.cpp:54:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 30 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 336075 [details]
Patch

Clearing flags on attachment: 336075

Committed r229735: <https://trac.webkit.org/changeset/229735>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.