Bug 18360 - "missing sentinel" warnings in PluginDatabaseGtk.cpp
Summary: "missing sentinel" warnings in PluginDatabaseGtk.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-08 05:05 PDT by Christian Persch (GNOME) (away; not reading bugmail)
Modified: 2008-04-08 20:23 PDT (History)
1 user (show)

See Also:


Attachments
patch (3.26 KB, patch)
2008-04-08 05:16 PDT, Christian Persch (GNOME) (away; not reading bugmail)
alp: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Persch (GNOME) (away; not reading bugmail) 2008-04-08 05:05:31 PDT
../WebCore/plugins/gtk/PluginDatabaseGtk.cpp:51: warning: missing sentinel in function call
[etc.]

This stems from http://bugs.webkit.org/show_bug.cgi?id=17825#c2 . Since g_build_filename is a varargs call, the sentinel should be NULL, not 0.
Comment 1 Christian Persch (GNOME) (away; not reading bugmail) 2008-04-08 05:16:54 PDT
Created attachment 20403 [details]
patch
Comment 2 Alp Toker 2008-04-08 20:22:22 PDT
Comment on attachment 20403 [details]
patch

r=me

Needs some massaging to apply to TOT.
Comment 3 Alp Toker 2008-04-08 20:23:03 PDT
Landed in r31747.