Swap the aspectRatioNumerator and aspectRatioDenomirator in the formula. "height * (static_cast<float>(pixelAspectRatioDenominator) / static_cast<float>(pixelAspectRatioNumerator))" instead of "height * (static_cast<float>(pixelAspectRatioNumerator) / static_cast<float>(pixelAspectRatioDenominator))"
Created attachment 335687 [details] Patch
Comment on attachment 335687 [details] Patch Oops! I think it would be nice to have a test for this does not happen again.
(In reply to Xabier Rodríguez Calvar from comment #2) > Comment on attachment 335687 [details] > Patch > > Oops! > > I think it would be nice to have a test for this does not happen again. I'll see what I can do for the test.
(In reply to Yacine Bandou from comment #3) > (In reply to Xabier Rodríguez Calvar from comment #2) > > Comment on attachment 335687 [details] > > Patch > > > > Oops! > > > > I think it would be nice to have a test for this does not happen again. > > I'll see what I can do for the test. Hi Yacine! Are you still willing to write a test case for this? Note that the function was moved to “GStramerCommon.cpp” a while ago.
Lack of time, I can't do it now.
*** This bug has been marked as a duplicate of bug 190464 ***
I did a lousy review of bug 190464 and we should keep this open to track a possible test so that that bug does not regress. Besides, it's a pity that the patch does not have the proper author, who should be Yacine, sorry for that.