REOPENED 183591
[MSE][GStreamer] Provide a test for r237033 
https://bugs.webkit.org/show_bug.cgi?id=183591
Summary [MSE][GStreamer] Provide a test for r237033
Yacine Bandou
Reported 2018-03-13 03:27:34 PDT
Swap the aspectRatioNumerator and aspectRatioDenomirator in the formula. "height * (static_cast<float>(pixelAspectRatioDenominator) / static_cast<float>(pixelAspectRatioNumerator))" instead of "height * (static_cast<float>(pixelAspectRatioNumerator) / static_cast<float>(pixelAspectRatioDenominator))"
Attachments
Patch (1.80 KB, patch)
2018-03-13 03:36 PDT, Yacine Bandou 		calvaris: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yacine Bandou
Comment 1 2018-03-13 03:36:22 PDT
Created attachment 335687 [details] Patch
Xabier Rodríguez Calvar
Comment 2 2018-03-13 04:33:30 PDT
Comment on attachment 335687 [details] Patch Oops! I think it would be nice to have a test for this does not happen again.
Yacine Bandou
Comment 3 2018-03-15 02:50:39 PDT
(In reply to Xabier Rodríguez Calvar from comment #2) > Comment on attachment 335687 [details] > Patch > > Oops! > > I think it would be nice to have a test for this does not happen again. I'll see what I can do for the test.
Adrian Perez
Comment 4 2018-07-26 09:21:59 PDT
(In reply to Yacine Bandou from comment #3) > (In reply to Xabier Rodríguez Calvar from comment #2) > > Comment on attachment 335687 [details] > > Patch > > > > Oops! > > > > I think it would be nice to have a test for this does not happen again. > > I'll see what I can do for the test. Hi Yacine! Are you still willing to write a test case for this? Note that the function was moved to “GStramerCommon.cpp” a while ago.
Yacine Bandou
Comment 5 2018-07-26 09:56:16 PDT
Lack of time, I can't do it now.
Philippe Normand
Comment 6 2018-10-11 04:44:59 PDT
*** This bug has been marked as a duplicate of bug 190464 ***
Xabier Rodríguez Calvar
Comment 7 2018-10-11 06:48:54 PDT
I did a lousy review of bug 190464 and we should keep this open to track a possible test so that that bug does not regress. Besides, it's a pity that the patch does not have the proper author, who should be Yacine, sorry for that.
Note You need to log in before you can comment on or make changes to this bug.