Bug 183590 – [DFG][FTL] Make ArraySlice(0) code tight

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Yusuke Suzuki]

[DFG][FTL] Make ArraySlice(0) code tight

[Yusuke Suzuki]

Created attachment 335683 [details]
Patch

[EWS Watchlist]

Attachment 335683 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:7632:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Yusuke Suzuki]

Created attachment 335688 [details]
Patch

[EWS Watchlist]

Attachment 335688 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:7624:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:7635:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:7689:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 3 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Saam Barati]

Comment on attachment 335688 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335688&action=review

> Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:1079
> +                fixEdge<Int32Use>(m_graph.varArgChild(node, 1));

Don’t you want to do this if count >= 2?

> Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:1080
> +                if (node->numChildren() == 4)

Ignore above comment (bugzilla on my phone is not allowing me to delete the above comment). I misread the code.

[Yusuke Suzuki]

Comment on attachment 335688 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335688&action=review

>> Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:1080
>> +                if (node->numChildren() == 4)
> 
> Ignore above comment (bugzilla on my phone is not allowing me to delete the above comment). I misread the code.

OK, thanks!

[Yusuke Suzuki]

Committed r229742: <https://trac.webkit.org/changeset/229742>

[Radar WebKit Bug Importer]

<rdar://problem/38653765>