Bug 183588 - fast/loader/javascript-url-iframe-remove-on-navigate.html is flaky with async policy delegates
Summary: fast/loader/javascript-url-iframe-remove-on-navigate.html is flaky with async...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 180568
  Show dependency tree / graph
 
Reported: 2018-03-12 20:25 PDT by Chris Dumez
Modified: 2018-03-13 11:08 PDT (History)
6 users (show)

See Also:

Attachments
Patch (4.19 KB, patch)
2018-03-13 10:00 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2018-03-12 20:25:34 PDT 
fast/loader/javascript-url-iframe-remove-on-navigate.html is flaky with async policy delegates:
--- /Volumes/Data/EWS/WebKit/WebKitBuild/Release/layout-test-results/fast/loader/javascript-url-iframe-remove-on-navigate-expected.txt
+++ /Volumes/Data/EWS/WebKit/WebKitBuild/Release/layout-test-results/fast/loader/javascript-url-iframe-remove-on-navigate-actual.txt
@@ -1,2 +1 @@
-Blocked access to external URL http://does.not.exist/
 PASS - Javascript URL blocked without crashing.
Comment 1 Chris Dumez 2018-03-12 20:27:44 PDT 
Also:
--- /Volumes/Data/WebKit/OpenSource/WebKitBuild/Debug/layout-test-results/fast/loader/javascript-url-iframe-remove-on-navigate-expected.txt
+++ /Volumes/Data/WebKit/OpenSource/WebKitBuild/Debug/layout-test-results/fast/loader/javascript-url-iframe-remove-on-navigate-actual.txt
@@ -1,2 +1,2 @@
-Blocked access to external URL http://does.not.exist/
+ALERT: FAIL
 PASS - Javascript URL blocked without crashing.
Comment 2 Chris Dumez 2018-03-13 10:00:01 PDT 
Created attachment 335701 [details]
Patch
Comment 3 Ryosuke Niwa 2018-03-13 11:06:18 PDT 
Comment on attachment 335701 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335701&action=review

> LayoutTests/ChangeLog:15
> +        I checked that this test was printing the "FAIL" alert in both Firefox and Chrome before
> +        this change.

So both Chrome & Firefox run javascript protocol async?
Comment 4 WebKit Commit Bot 2018-03-13 11:07:35 PDT 
Comment on attachment 335701 [details]
Patch

Clearing flags on attachment: 335701

Committed r229579: <https://trac.webkit.org/changeset/229579>
Comment 5 WebKit Commit Bot 2018-03-13 11:07:36 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-03-13 11:08:20 PDT 
<rdar://problem/38423408>