WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
183588
fast/loader/javascript-url-iframe-remove-on-navigate.html is flaky with async policy delegates
https://bugs.webkit.org/show_bug.cgi?id=183588
Summary
fast/loader/javascript-url-iframe-remove-on-navigate.html is flaky with async...
Chris Dumez
Reported
2018-03-12 20:25:34 PDT
fast/loader/javascript-url-iframe-remove-on-navigate.html is flaky with async policy delegates: --- /Volumes/Data/EWS/WebKit/WebKitBuild/Release/layout-test-results/fast/loader/javascript-url-iframe-remove-on-navigate-expected.txt +++ /Volumes/Data/EWS/WebKit/WebKitBuild/Release/layout-test-results/fast/loader/javascript-url-iframe-remove-on-navigate-actual.txt @@ -1,2 +1 @@ -Blocked access to external URL
http://does.not.exist/
PASS - Javascript URL blocked without crashing.
Attachments
Patch
(4.19 KB, patch)
2018-03-13 10:00 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2018-03-12 20:27:44 PDT
Also: --- /Volumes/Data/WebKit/OpenSource/WebKitBuild/Debug/layout-test-results/fast/loader/javascript-url-iframe-remove-on-navigate-expected.txt +++ /Volumes/Data/WebKit/OpenSource/WebKitBuild/Debug/layout-test-results/fast/loader/javascript-url-iframe-remove-on-navigate-actual.txt @@ -1,2 +1,2 @@ -Blocked access to external URL
http://does.not.exist/
+ALERT: FAIL PASS - Javascript URL blocked without crashing.
Chris Dumez
Comment 2
2018-03-13 10:00:01 PDT
Created
attachment 335701
[details]
Patch
Ryosuke Niwa
Comment 3
2018-03-13 11:06:18 PDT
Comment on
attachment 335701
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=335701&action=review
> LayoutTests/ChangeLog:15 > + I checked that this test was printing the "FAIL" alert in both Firefox and Chrome before > + this change.
So both Chrome & Firefox run javascript protocol async?
WebKit Commit Bot
Comment 4
2018-03-13 11:07:35 PDT
Comment on
attachment 335701
[details]
Patch Clearing flags on attachment: 335701 Committed
r229579
: <
https://trac.webkit.org/changeset/229579
>
WebKit Commit Bot
Comment 5
2018-03-13 11:07:36 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6
2018-03-13 11:08:20 PDT
<
rdar://problem/38423408
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug