Bug 183584 - Ignore some deprecation warnings encountered when compiling with newer versions of ICU
Summary: Ignore some deprecation warnings encountered when compiling with newer versio...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: BJ Burg
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-03-12 16:28 PDT by BJ Burg
Modified: 2018-03-12 16:54 PDT (History)
5 users (show)

See Also:


Attachments
Patch (4.21 KB, patch)
2018-03-12 16:32 PDT, BJ Burg
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2018-03-12 16:28:22 PDT
.
Comment 1 BJ Burg 2018-03-12 16:28:42 PDT
<rdar://problem/38395317>
Comment 2 BJ Burg 2018-03-12 16:32:54 PDT
Created attachment 335662 [details]
Patch
Comment 3 BJ Burg 2018-03-12 16:33:36 PDT
Reviewed offline by dbates.
Comment 4 Myles C. Maxfield 2018-03-12 16:37:12 PDT
Comment on attachment 335662 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335662&action=review

> Source/WebCore/editing/TextIterator.cpp:2004
> +#pragma clang diagnostic ignored "-Wdeprecated-declarations"

Usually we do this around each individual call.

> Source/WebCore/platform/graphics/SurrogatePairAwareTextIterator.cpp:74
> +#pragma clang diagnostic ignored "-Wdeprecated-declarations"

Ditto.

> Source/WebCore/platform/text/TextEncoding.cpp:74
> +#pragma clang diagnostic ignored "-Wdeprecated-declarations"

Ditto.
Comment 5 BJ Burg 2018-03-12 16:46:11 PDT
Committed r229564: <https://trac.webkit.org/changeset/229564>
Comment 6 mitz 2018-03-12 16:54:29 PDT
Please just bug 183355 already.