RESOLVED FIXED 183582
Add a WKWebViewContentProvider for system previews 
https://bugs.webkit.org/show_bug.cgi?id=183582
Summary Add a WKWebViewContentProvider for system previews
Dean Jackson
Reported 2018-03-12 15:25:18 PDT
Add a WKWebViewContentProvider for system previews
Attachments
Patch (27.61 KB, patch)
2018-03-12 15:34 PDT, Dean Jackson 		thorton: review+
DetailsFormatted DiffDiff
Patch for EWS (27.62 KB, patch)
2018-03-12 15:48 PDT, Dean Jackson 		no flags
DetailsFormatted DiffDiff
Patch 3 for EWS (28.47 KB, patch)
2018-03-12 20:08 PDT, Dean Jackson 		no flags
DetailsFormatted DiffDiff
Patch 4 for EWS (28.10 KB, patch)
2018-03-12 20:25 PDT, Dean Jackson 		no flags
DetailsFormatted DiffDiff
Patch 5 for EWS - damn you external sdk (28.17 KB, patch)
2018-03-12 20:38 PDT, Dean Jackson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-03-12 15:26:16 PDT
<rdar://problem/38393569>
Dean Jackson
Comment 2 2018-03-12 15:34:55 PDT
Created attachment 335653 [details] Patch
Tim Horton
Comment 3 2018-03-12 15:38:27 PDT
Comment on attachment 335653 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=335653&action=review > Source/WebKit/UIProcess/Cocoa/WKWebViewContentProviderRegistry.mm:64 > +#if PLATFORM(IOS) && USE(QUICK_LOOK) && USE(APPLE_INTERNAL_SDK) At some point you might want to give up and add ENABLE(SYSTEM_PREVIEW_VIEW) or something
Dean Jackson
Comment 4 2018-03-12 15:44:13 PDT
(In reply to Tim Horton from comment #3) > At some point you might want to give up Constantly.
Dean Jackson
Comment 5 2018-03-12 15:44:45 PDT
Just need to fix the public bots.
Dean Jackson
Comment 6 2018-03-12 15:48:36 PDT
Created attachment 335655 [details] Patch for EWS
Dean Jackson
Comment 7 2018-03-12 20:08:29 PDT
Created attachment 335675 [details] Patch 3 for EWS
Dean Jackson
Comment 8 2018-03-12 20:25:20 PDT
Created attachment 335678 [details] Patch 4 for EWS
Dean Jackson
Comment 9 2018-03-12 20:38:17 PDT
Created attachment 335680 [details] Patch 5 for EWS - damn you external sdk
Dean Jackson
Comment 10 2018-03-12 21:11:38 PDT
Committed r229573: <https://trac.webkit.org/changeset/229573>
Note You need to log in before you can comment on or make changes to this bug.