Bug 183582 - Add a WKWebViewContentProvider for system previews
Summary: Add a WKWebViewContentProvider for system previews
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-03-12 15:25 PDT by Dean Jackson
Modified: 2018-03-12 21:11 PDT (History)
2 users (show)

See Also:


Attachments
Patch (27.61 KB, patch)
2018-03-12 15:34 PDT, Dean Jackson
thorton: review+
Details | Formatted Diff | Diff
Patch for EWS (27.62 KB, patch)
2018-03-12 15:48 PDT, Dean Jackson
no flags Details | Formatted Diff | Diff
Patch 3 for EWS (28.47 KB, patch)
2018-03-12 20:08 PDT, Dean Jackson
no flags Details | Formatted Diff | Diff
Patch 4 for EWS (28.10 KB, patch)
2018-03-12 20:25 PDT, Dean Jackson
no flags Details | Formatted Diff | Diff
Patch 5 for EWS - damn you external sdk (28.17 KB, patch)
2018-03-12 20:38 PDT, Dean Jackson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2018-03-12 15:25:18 PDT
Add a WKWebViewContentProvider for system previews
Comment 1 Radar WebKit Bug Importer 2018-03-12 15:26:16 PDT
<rdar://problem/38393569>
Comment 2 Dean Jackson 2018-03-12 15:34:55 PDT
Created attachment 335653 [details]
Patch
Comment 3 Tim Horton 2018-03-12 15:38:27 PDT
Comment on attachment 335653 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335653&action=review

> Source/WebKit/UIProcess/Cocoa/WKWebViewContentProviderRegistry.mm:64
> +#if PLATFORM(IOS) && USE(QUICK_LOOK) && USE(APPLE_INTERNAL_SDK)

At some point you might want to give up and add ENABLE(SYSTEM_PREVIEW_VIEW) or something
Comment 4 Dean Jackson 2018-03-12 15:44:13 PDT
(In reply to Tim Horton from comment #3)

> At some point you might want to give up

Constantly.
Comment 5 Dean Jackson 2018-03-12 15:44:45 PDT
Just need to fix the public bots.
Comment 6 Dean Jackson 2018-03-12 15:48:36 PDT
Created attachment 335655 [details]
Patch for EWS
Comment 7 Dean Jackson 2018-03-12 20:08:29 PDT
Created attachment 335675 [details]
Patch 3 for EWS
Comment 8 Dean Jackson 2018-03-12 20:25:20 PDT
Created attachment 335678 [details]
Patch 4 for EWS
Comment 9 Dean Jackson 2018-03-12 20:38:17 PDT
Created attachment 335680 [details]
Patch 5 for EWS - damn you external sdk
Comment 10 Dean Jackson 2018-03-12 21:11:38 PDT
Committed r229573: <https://trac.webkit.org/changeset/229573>