Bug 183567 - Return boolean from DOMTokenList's replace() method
Summary: Return boolean from DOMTokenList's replace() method
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on: 183570
Blocks:
  Show dependency tree / graph
 
Reported: 2018-03-12 07:44 PDT by Magne Andersson
Modified: 2018-03-12 18:38 PDT (History)
11 users (show)

See Also:

Attachments
Patch (39.26 KB, patch)
2018-03-12 14:35 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Magne Andersson 2018-03-12 07:44:32 PDT 
A proposed change to the specification for DOMTokenList's replace() method which would make it return a boolean - indicating true if a token was replaced and false otherwise - has received positive responses from implementers.

Pull request and discussion: https://github.com/whatwg/dom/pull/582

Tests: https://github.com/w3c/web-platform-tests/pull/9920
Comment 1 Chris Dumez 2018-03-12 14:35:35 PDT 
Created attachment 335640 [details]
Patch
Comment 2 WebKit Commit Bot 2018-03-12 18:37:27 PDT 
Comment on attachment 335640 [details]
Patch

Clearing flags on attachment: 335640

Committed r229566: <https://trac.webkit.org/changeset/229566>
Comment 3 WebKit Commit Bot 2018-03-12 18:37:29 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2018-03-12 18:38:19 PDT 
<rdar://problem/38400456>