Bug 183535 - [WebAuthN] Improve CBOR encoding/decoding
Summary: [WebAuthN] Improve CBOR encoding/decoding
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: InRadar
Depends on:
Blocks: 181943
  Show dependency treegraph
Reported: 2018-03-09 15:57 PST by Jiewen Tan
Modified: 2020-03-08 21:59 PDT (History)
5 users (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Jiewen Tan 2018-03-09 15:57:31 PST
CBOR encoder needs to deal with bytes directly.
Comment 1 Radar WebKit Bug Importer 2018-08-15 17:09:23 PDT
Comment 2 Jiewen Tan 2018-10-01 17:13:48 PDT
Actually, this bug applies to all different value types the encoder support. Instead of holding the value, the encoder will be more efficient to provide a mode to only hold a reference to the value and then let the caller to guarantee the value is unchanged and alive during the encoding period. Anyway, it will be good to optimize it but not a blocker for the feature.
Comment 3 Jiewen Tan 2020-03-08 21:59:23 PDT
We should consider adding && getter for CBORValue.