Currently code does callback->sendFailure, and some code just sets the ErrorString, which doesn't really do anything. Don't include an ErrorString out-param for async backend commands.
Created attachment 335471 [details] Patch
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Attachment 335471 [details] did not pass style-queue: ERROR: Source/WebCore/inspector/agents/InspectorIndexedDBAgent.cpp:567: out_document is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/inspector/agents/InspectorIndexedDBAgent.cpp:567: out_idbFactory is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/inspector/agents/InspectorIndexedDBAgent.h:66: in_securityOrigin is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/inspector/agents/InspectorIndexedDBAgent.h:66: in_databaseName is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/inspector/agents/InspectorIndexedDBAgent.h:66: in_objectStoreName is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 5 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 335471 [details] Patch Nice!
Comment on attachment 335471 [details] Patch Clearing flags on attachment: 335471 Committed r229493: <https://trac.webkit.org/changeset/229493>
All reviewed patches have been landed. Closing bug.
<rdar://problem/38397805>