RESOLVED FIXED 183524
Web Inspector: there should only be one way for async backend commands to send failure 
https://bugs.webkit.org/show_bug.cgi?id=183524
Summary Web Inspector: there should only be one way for async backend commands to sen...
Blaze Burg
Reported 2018-03-09 14:12:52 PST
Currently code does callback->sendFailure, and some code just sets the ErrorString, which doesn't really do anything. Don't include an ErrorString out-param for async backend commands.
Attachments
Patch (86.52 KB, patch)
2018-03-09 15:07 PST, Blaze Burg 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Blaze Burg
Comment 1 2018-03-09 15:07:54 PST
Created attachment 335471 [details] Patch
EWS Watchlist
Comment 2 2018-03-09 15:12:26 PST
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
EWS Watchlist
Comment 3 2018-03-09 15:12:40 PST
Attachment 335471 [details] did not pass style-queue: ERROR: Source/WebCore/inspector/agents/InspectorIndexedDBAgent.cpp:567: out_document is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/inspector/agents/InspectorIndexedDBAgent.cpp:567: out_idbFactory is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/inspector/agents/InspectorIndexedDBAgent.h:66: in_securityOrigin is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/inspector/agents/InspectorIndexedDBAgent.h:66: in_databaseName is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/inspector/agents/InspectorIndexedDBAgent.h:66: in_objectStoreName is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 5 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.
Timothy Hatcher
Comment 4 2018-03-09 15:32:38 PST
Comment on attachment 335471 [details] Patch Nice!
WebKit Commit Bot
Comment 5 2018-03-09 16:43:09 PST
Comment on attachment 335471 [details] Patch Clearing flags on attachment: 335471 Committed r229493: <https://trac.webkit.org/changeset/229493>
WebKit Commit Bot
Comment 6 2018-03-09 16:43:11 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-03-12 17:22:39 PDT
<rdar://problem/38397805>
Note You need to log in before you can comment on or make changes to this bug.