Bug 183512 – Move jsc CLI breakpoint function to $vm

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Keith Miller]

Move jsc CLI breakpoint function to $vm

[Keith Miller]

Created attachment 335423 [details]
Patch

[EWS Watchlist]

Attachment 335423 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/ChangeLog:8:  Please consider whether the use of security-sensitive phrasing could help someone exploit WebKit: fuzzer  [changelog/unwantedsecurityterms] [3]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Yusuke Suzuki]

Comment on attachment 335423 [details]
Patch

r=me, nice.

[Yusuke Suzuki]

Comment on attachment 335423 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335423&action=review

> Source/JavaScriptCore/jsc.cpp:582
> +        addFunction(vm, dollar, "breakpoint", functionBreakpoint, 0);

I think, this is `$.breakpoint`, not `$vm.breakpoint`, correct?
You can move this to tools/JSDollarVM.cpp

[Mark Lam]

Comment on attachment 335423 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335423&action=review

>> Source/JavaScriptCore/jsc.cpp:582
>> +        addFunction(vm, dollar, "breakpoint", functionBreakpoint, 0);
> 
> I think, this is `$.breakpoint`, not `$vm.breakpoint`, correct?
> You can move this to tools/JSDollarVM.cpp

Yes, to put this in $vm, you should add it in JSDollarVM.

[David Kilzer (:ddkilzer)]

<rdar://problem/38462027>

[Keith Miller]

Created attachment 335783 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 335783 [details]
Patch for landing

Clearing flags on attachment: 335783

Committed r229605: <https://trac.webkit.org/changeset/229605>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.