Move jsc CLI breakpoint function to $vm
Created attachment 335423 [details] Patch
Attachment 335423 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/ChangeLog:8: Please consider whether the use of security-sensitive phrasing could help someone exploit WebKit: fuzzer [changelog/unwantedsecurityterms] [3] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 335423 [details] Patch r=me, nice.
Comment on attachment 335423 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=335423&action=review > Source/JavaScriptCore/jsc.cpp:582 > + addFunction(vm, dollar, "breakpoint", functionBreakpoint, 0); I think, this is `$.breakpoint`, not `$vm.breakpoint`, correct? You can move this to tools/JSDollarVM.cpp
Comment on attachment 335423 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=335423&action=review >> Source/JavaScriptCore/jsc.cpp:582 >> + addFunction(vm, dollar, "breakpoint", functionBreakpoint, 0); > > I think, this is `$.breakpoint`, not `$vm.breakpoint`, correct? > You can move this to tools/JSDollarVM.cpp Yes, to put this in $vm, you should add it in JSDollarVM.
<rdar://problem/38462027>
Created attachment 335783 [details] Patch for landing
Comment on attachment 335783 [details] Patch for landing Clearing flags on attachment: 335783 Committed r229605: <https://trac.webkit.org/changeset/229605>
All reviewed patches have been landed. Closing bug.