Bug 183510 – [GTK] Do not use WebKitDOMHTMLFormElement as argument of signal WebKitWebPage::will-submit-form

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Carlos Garcia Campos]

In 2.22 WebKitDOMHTMLFormElement will be deprecated in GTK+ port and won't still exist in WPE. The new JavaScript GLib API will be used to replace most of the DOM API, but a few classes will remain with a minimal API for things that can't be done with JavaScript. WebKitDOMElement will stay and will be added to WPE as well, so if we change the signal parameter to WebKitDOMElement we will be able to keep using WebKitWebPage::will-submit-form without any changes. WPE will gain this signal and the rest of the API that uses DOM. We need to do this before 2.20, since this is new API.

[Carlos Garcia Campos]

Created attachment 335416 [details]
Patch

[EWS Watchlist]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Michael Catanzaro]

Comment on attachment 335416 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335416&action=review

> Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitWebPage.cpp:594
> +     * @form: the #WebKitDOMElement to be submitted

the #WebKitDOMElement to be submitted, which will always correspond to an HTMLFormElement

> Tools/TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:385
> +    GUniquePtr<char> formID(webkit_dom_element_get_id(formElement));

Oops. I wish it was not transfer full. :( But I guess the ID can change at any time.

[Carlos Garcia Campos]

Committed r229461: <https://trac.webkit.org/changeset/229461>