Unconditionalize more methods in VideoFullscreenInterface (and related classes)
Created attachment 335400 [details] Patch
Created attachment 335442 [details] Patch
Created attachment 335443 [details] Patch
<rdar://problem/38312038>
Comment on attachment 335443 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=335443&action=review > Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.h:154 > + bool isPlayingVideoInEnhancedFullscreen() const; Huh, I thought we got rid of "EnhancedFullscreen". Can you change this to something like "isPlayingVideoInPictureInPicture" as long as you are updating?
(In reply to Eric Carlson from comment #5) > Comment on attachment 335443 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=335443&action=review > > > Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.h:154 > > + bool isPlayingVideoInEnhancedFullscreen() const; > > Huh, I thought we got rid of "EnhancedFullscreen". Can you change this to > something like "isPlayingVideoInPictureInPicture" as long as you are > updating? We'd have to change it everywhere at once, but I could take a stab at it.
Created attachment 335461 [details] Patch for landing
Comment on attachment 335461 [details] Patch for landing Clearing flags on attachment: 335461 Committed r229485: <https://trac.webkit.org/changeset/229485>
All reviewed patches have been landed. Closing bug.
Landed follow-up build fix in http://trac.webkit.org/r229494