Bug 183501 – Unconditionalize more methods in VideoFullscreenInterface (and related classes)

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jer Noble]

Unconditionalize more methods in VideoFullscreenInterface (and related classes)

[Jer Noble]

Created attachment 335400 [details]
Patch

[Jer Noble]

Created attachment 335442 [details]
Patch

[Jer Noble]

Created attachment 335443 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/38312038>

[Eric Carlson]

Comment on attachment 335443 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335443&action=review

> Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.h:154
> +    bool isPlayingVideoInEnhancedFullscreen() const;

Huh, I thought we got rid of "EnhancedFullscreen". Can you change this to something like "isPlayingVideoInPictureInPicture" as long as you are updating?

[Jer Noble]

(In reply to Eric Carlson from comment #5)
> Comment on attachment 335443 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=335443&action=review
> 
> > Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.h:154
> > +    bool isPlayingVideoInEnhancedFullscreen() const;
> 
> Huh, I thought we got rid of "EnhancedFullscreen". Can you change this to
> something like "isPlayingVideoInPictureInPicture" as long as you are
> updating?

We'd have to change it everywhere at once, but I could take a stab at it.

[Jer Noble]

Created attachment 335461 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 335461 [details]
Patch for landing

Clearing flags on attachment: 335461

Committed r229485: <https://trac.webkit.org/changeset/229485>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Jer Noble]

Landed follow-up build fix in http://trac.webkit.org/r229494