Bug 183500 – Add basic synchronization capability to Nicosia::Buffer

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Zan Dobersek]

Add basic synchronization capability to Nicosia::Buffer

[Zan Dobersek]

Created attachment 335401 [details]
Patch

[EWS Watchlist]

Attachment 335401 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/nicosia/NicosiaBuffer.cpp:72:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Carlos Garcia Campos]

Comment on attachment 335401 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335401&action=review

> Source/WebCore/platform/graphics/nicosia/NicosiaBuffer.cpp:58
> +    m_painting.state = PaintingState::InProgress;

Should we assert here that state as complete?

> Source/WebCore/platform/graphics/nicosia/NicosiaBuffer.cpp:64
> +    m_painting.state = PaintingState::Complete;

And here that is in progress?

[Zan Dobersek]

Comment on attachment 335401 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335401&action=review

>> Source/WebCore/platform/graphics/nicosia/NicosiaBuffer.cpp:58
>> +    m_painting.state = PaintingState::InProgress;
> 
> Should we assert here that state as complete?

Makes sense.

>> Source/WebCore/platform/graphics/nicosia/NicosiaBuffer.cpp:64
>> +    m_painting.state = PaintingState::Complete;
> 
> And here that is in progress?

Right.

[Zan Dobersek]

Created attachment 335402 [details]
Patch for landing

[Zan Dobersek]

Comment on attachment 335402 [details]
Patch for landing

Clearing flags on attachment: 335402

Committed r229454: <https://trac.webkit.org/changeset/229454>

[Zan Dobersek]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/38293587>