Bug 183498 - Add new CSS env constants for use with fullscreen
Summary: Add new CSS env constants for use with fullscreen
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-03-08 23:04 PST by Jer Noble
Modified: 2018-03-09 11:21 PST (History)
8 users (show)

See Also:

Attachments
Patch (20.16 KB, patch)
2018-03-08 23:08 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (20.09 KB, patch)
2018-03-09 10:03 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2018-03-08 23:04:47 PST 
Add new CSS env constants for use with fullscreen
Comment 1 Jer Noble 2018-03-08 23:08:58 PST 
Created attachment 335398 [details]
Patch
Comment 2 Jer Noble 2018-03-09 10:03:11 PST 
Created attachment 335434 [details]
Patch
Comment 3 Dean Jackson 2018-03-09 10:33:55 PST 
Comment on attachment 335434 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335434&action=review

> Source/WebCore/dom/ConstantPropertyMap.cpp:58
> +    static NeverDestroyed<AtomicString> fullscreenInsetTopName("fullscreen-inset-top", AtomicString::ConstructFromLiteral);
> +    static NeverDestroyed<AtomicString> fullscreenAutoHideDelayName("fullscreen-auto-hide-delay", AtomicString::ConstructFromLiteral);

I'm fine with these names for now, but we should start the standardization process right away.
Comment 4 WebKit Commit Bot 2018-03-09 11:20:36 PST 
Comment on attachment 335434 [details]
Patch

Clearing flags on attachment: 335434

Committed r229475: <https://trac.webkit.org/changeset/229475>
Comment 5 WebKit Commit Bot 2018-03-09 11:20:37 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-03-09 11:21:18 PST 
<rdar://problem/38310040>