RESOLVED FIXED 183498
Add new CSS env constants for use with fullscreen 
https://bugs.webkit.org/show_bug.cgi?id=183498
Summary Add new CSS env constants for use with fullscreen
Jer Noble
Reported 2018-03-08 23:04:47 PST
Add new CSS env constants for use with fullscreen
Attachments
Patch (20.16 KB, patch)
2018-03-08 23:08 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (20.09 KB, patch)
2018-03-09 10:03 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2018-03-08 23:08:58 PST
Created attachment 335398 [details] Patch
Jer Noble
Comment 2 2018-03-09 10:03:11 PST
Created attachment 335434 [details] Patch
Dean Jackson
Comment 3 2018-03-09 10:33:55 PST
Comment on attachment 335434 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=335434&action=review > Source/WebCore/dom/ConstantPropertyMap.cpp:58 > + static NeverDestroyed<AtomicString> fullscreenInsetTopName("fullscreen-inset-top", AtomicString::ConstructFromLiteral); > + static NeverDestroyed<AtomicString> fullscreenAutoHideDelayName("fullscreen-auto-hide-delay", AtomicString::ConstructFromLiteral); I'm fine with these names for now, but we should start the standardization process right away.
WebKit Commit Bot
Comment 4 2018-03-09 11:20:36 PST
Comment on attachment 335434 [details] Patch Clearing flags on attachment: 335434 Committed r229475: <https://trac.webkit.org/changeset/229475>
WebKit Commit Bot
Comment 5 2018-03-09 11:20:37 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-03-09 11:21:18 PST
<rdar://problem/38310040>
Note You need to log in before you can comment on or make changes to this bug.