RESOLVED FIXED 183488
testmasm crashes in testBranchTruncateDoubleToInt32() on ARM64 
https://bugs.webkit.org/show_bug.cgi?id=183488
Summary testmasm crashes in testBranchTruncateDoubleToInt32() on ARM64
Michael Saboff
Reported 2018-03-08 17:21:25 PST
The code was written by adjusting sp down by 8 bytes. ARM64 hardware asserts that sp is 16 byte align when used as the destination of the load/store. The fix is to keep the stack aligned.
Attachments
Patch for landing (2.09 KB, patch)
2018-03-08 17:30 PST, Michael Saboff 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2018-03-08 17:30:08 PST
Created attachment 335371 [details] Patch for landing
Michael Saboff
Comment 2 2018-03-08 17:46:25 PST
Committed r229446: <https://trac.webkit.org/changeset/229446>
Radar WebKit Bug Importer
Comment 3 2018-03-08 17:47:18 PST
<rdar://problem/38285026>
Ryan Haddad
Comment 4 2018-03-09 10:00:14 PST
Reverted r229446 for reason: This change relies on changes that have been rolled out. Committed r229464: <https://trac.webkit.org/changeset/229464>
Matt Lewis
Comment 5 2018-03-09 13:15:34 PST
This looks to have broke The High Sierra LLINT CLoop build when it was re-landed in https://trac.webkit.org/changeset/229476/webkit https://build.webkit.org/builders/Apple%20High%20Sierra%20LLINT%20CLoop%20%28BuildAndTest%29/builds/4330 https://build.webkit.org/builders/Apple%20High%20Sierra%20LLINT%20CLoop%20%28BuildAndTest%29/builds/4330/steps/compile-webkit/logs/stdio /Volumes/Data/slave/highsierra-cloop-debug/build/Source/JavaScriptCore/runtime/StackAlignment.h:45:80: error: use of undeclared identifier 'CallFrame' /Volumes/Data/slave/highsierra-cloop-debug/build/Source/JavaScriptCore/runtime/StackAlignment.h:45:116: error: use of undeclared identifier 'CallFrame' /Volumes/Data/slave/highsierra-cloop-debug/build/Source/JavaScriptCore/runtime/StackAlignment.h:52:85: error: use of undeclared identifier 'CallerFrameAndPC' /Volumes/Data/slave/highsierra-cloop-debug/build/Source/JavaScriptCore/runtime/StackAlignment.h:52:122: error: use of undeclared identifier 'CallerFrameAndPC'
Mark Lam
Comment 6 2018-03-09 15:04:14 PST
Michael relanded the patch in r229476: <http://trac.webkit.org/r229476>.
Mark Lam
Comment 7 2018-03-09 15:08:10 PST
Build fix landed in r229486: <http://trac.webkit.org/r229486>.
Note You need to log in before you can comment on or make changes to this bug.