Bug 183482 - Ensure default appearance for selection form control
Summary: Ensure default appearance for selection form control
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
Keywords: InRadar
Depends on:
Reported: 2018-03-08 14:49 PST by Megan Gardner
Modified: 2018-03-08 15:21 PST (History)
4 users (show)

See Also:

Patch (1.29 KB, patch)
2018-03-08 14:51 PST, Megan Gardner
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2018-03-08 14:49:54 PST
Ensure default appearance for selection form control
Comment 1 Megan Gardner 2018-03-08 14:51:57 PST
Created attachment 335350 [details]
Comment 2 Radar WebKit Bug Importer 2018-03-08 14:52:35 PST
Comment 3 Tim Horton 2018-03-08 14:55:00 PST
Comment on attachment 335350 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=335350&action=review

> Source/WebCore/rendering/RenderThemeMac.mm:340
> +    LocalDefaultSystemAppearance localAppearance;

Should this just be inside platformInactiveSelectionBackgroundColor, where we presumably call to NSColor? Aren't there other callers?
Comment 4 Megan Gardner 2018-03-08 14:55:44 PST
Comment 5 Megan Gardner 2018-03-08 15:19:17 PST
possibly, but right now I'm trying to limit how deep everything is getting plumbed in the next patch.
Comment 6 Megan Gardner 2018-03-08 15:21:05 PST