WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
183482
Ensure default appearance for selection form control
https://bugs.webkit.org/show_bug.cgi?id=183482
Summary
Ensure default appearance for selection form control
Megan Gardner
Reported
2018-03-08 14:49:54 PST
Ensure default appearance for selection form control
Attachments
Patch
(1.29 KB, patch)
2018-03-08 14:51 PST
,
Megan Gardner
thorton
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Megan Gardner
Comment 1
2018-03-08 14:51:57 PST
Created
attachment 335350
[details]
Patch
Radar WebKit Bug Importer
Comment 2
2018-03-08 14:52:35 PST
<
rdar://problem/38278174
>
Tim Horton
Comment 3
2018-03-08 14:55:00 PST
Comment on
attachment 335350
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=335350&action=review
> Source/WebCore/rendering/RenderThemeMac.mm:340 > + LocalDefaultSystemAppearance localAppearance;
Should this just be inside platformInactiveSelectionBackgroundColor, where we presumably call to NSColor? Aren't there other callers?
Megan Gardner
Comment 4
2018-03-08 14:55:44 PST
<
rdar://problem/38274894
>
Megan Gardner
Comment 5
2018-03-08 15:19:17 PST
possibly, but right now I'm trying to limit how deep everything is getting plumbed in the next patch.
Megan Gardner
Comment 6
2018-03-08 15:21:05 PST
https://trac.webkit.org/changeset/229438/webkit
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug