Bug 183478 - Fix windows build
Summary: Fix windows build
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-08 13:35 PST by Keith Miller
Modified: 2018-03-08 14:43 PST (History)
5 users (show)

See Also:


Attachments
Patch (1.99 KB, patch)
2018-03-08 13:35 PST, Keith Miller
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2018-03-08 13:35:15 PST
Fix windows build
Comment 1 Keith Miller 2018-03-08 13:35:34 PST
Created attachment 335335 [details]
Patch
Comment 2 Mark Lam 2018-03-08 14:20:22 PST
Comment on attachment 335335 [details]
Patch

You've got so much red!
Comment 3 Mark Lam 2018-03-08 14:22:02 PST
Comment on attachment 335335 [details]
Patch

Nevermind.  The EWS bots are borked.  r=me
Comment 4 Keith Miller 2018-03-08 14:23:11 PST
Comment on attachment 335335 [details]
Patch

I was just trying to get EWS to run it... I didn't mean to put it up for review, sorry!
Comment 5 Aakash Jain 2018-03-08 14:43:38 PST
> Nevermind.  The EWS bots are borked.  r=me
EWS bots were fine in this case. 

The patch was landed manually in https://trac.webkit.org/r229424, before some of the EWS bots tried to apply the patch, and so got a svn conflict while applying the patch.