Bug 183472 - fast/events/before-unload-returnValue.html times out with async policy delegates
Summary: fast/events/before-unload-returnValue.html times out with async policy delegates
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 180568
  Show dependency treegraph
 
Reported: 2018-03-08 12:33 PST by Chris Dumez
Modified: 2018-03-08 21:57 PST (History)
7 users (show)

See Also:


Attachments
Patch (7.42 KB, patch)
2018-03-08 14:35 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2018-03-08 12:33:24 PST
fast/events/before-unload-returnValue.html times out with async policy delegates.
Comment 1 Chris Dumez 2018-03-08 13:27:22 PST
Seems to be related to this 0-timer:
    setTimeout(function() {
        if (window.testRunner)
            testRunner.setShouldStayOnPageAfterHandlingBeforeUnload(false);
        testIframe.contentWindow.location.href = "resources/does-not-exist.html";
    }, 0);

Using a larger than 0 value makes the test pass again.
Comment 2 Chris Dumez 2018-03-08 14:35:27 PST
Created attachment 335347 [details]
Patch
Comment 3 WebKit Commit Bot 2018-03-08 21:56:57 PST
Comment on attachment 335347 [details]
Patch

Clearing flags on attachment: 335347

Committed r229449: <https://trac.webkit.org/changeset/229449>
Comment 4 WebKit Commit Bot 2018-03-08 21:56:59 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-03-08 21:57:21 PST
<rdar://problem/38290505>