Bug 183468 - Resource Load Statistics: Make debug mode always partition prevalent resources
Summary: Resource Load Statistics: Make debug mode always partition prevalent resources
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: John Wilander
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-03-08 11:42 PST by John Wilander
Modified: 2018-03-08 13:36 PST (History)
2 users (show)

See Also:

Attachments
Patch (6.75 KB, patch)
2018-03-08 12:22 PST, John Wilander 		bfulgham: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Wilander 2018-03-08 11:42:11 PST 
After some testing we decided that a 30 second timeout in ITP debug mode just makes it confusing. We should instead always partition prevalent resources in debug mode to make it easy to understand. The partitioned state is what developers want to test anyway.
Comment 1 John Wilander 2018-03-08 11:43:34 PST 
<rdar://problem/38269437>
Comment 2 John Wilander 2018-03-08 12:22:21 PST 
Created attachment 335327 [details]
Patch
Comment 3 Brent Fulgham 2018-03-08 13:06:38 PST 
Comment on attachment 335327 [details]
Patch

Awesome! This should help us run through our tests more quickly, too. Thanks for adjusting this!
Comment 4 John Wilander 2018-03-08 13:11:52 PST 
Committed r229427: <https://trac.webkit.org/changeset/229427>